Forward-port the Virtualize MaxItemCount added in .NET 8 patch to .NET 9 RC1#57400
Merged
Merged
Conversation
SteveSandersonMS
added
the
ask-mode
ghost
added
the
SteveSandersonMS
changed the title
SteveSandersonMS
force-pushed
the
stevesa/port-virtualize-maxitemcount
branch
from
3da02fb to
3061fe3
Compare
javiercn
approved these changes
Aug 19, 2024
javiercn
added
Servicing-approved
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was referenced Aug 19, 2024
halter73
pushed a commit
that referenced
this pull request
Aug 28, 2024
…T 9 RC1 (#57400) * Limit MaxItemCount in Virtualize * Add public API for MaxItemCount
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port the Virtualize MaxItemCount added in .NET 8 patch
Ports the
MaxItemCountfix from .NET 8 to .NET 9.Description
See the original PR for full details of the original issue and the code review around this.
We had to delay this forward-porting until now because of the patch shipping timeline.
Customer Impact
If we don't forward-port this fix, the fix will be lost and the original defect would be reintroduced in .NET 9.
Regression?
Risk
It's the same code that has already shipped in a .NET 8 patch release, plus one extra bit of public API to make it easier to control (we couldn't add public API in the patch).
Verification
Packaging changes reviewed?