[release/5.0] Update dependencies from dotnet/efcore by dotnet-maestro[bot] · Pull Request #27189 · dotnet/aspnetcore

dotnet-maestro · 2020-10-24T06:19:28Z

This pull request updates the following dependencies

From https://github.com/dotnet/efcore

Subscription: 5a5466f0-17ae-442c-2f05-08d85e5f2673
Build: 20201023.3
Date Produced: 10/24/2020 7:24 AM
Commit: 33570d0337f76208fa3a814f7f6d3a506bd9c0be
Branch: refs/heads/release/5.0

Updates:
- Microsoft.EntityFrameworkCore.Tools: from 5.0.0 to 5.0.0
- dotnet-ef: from 5.0.0 to 5.0.0
- Microsoft.EntityFrameworkCore: from 5.0.0 to 5.0.0
- Microsoft.EntityFrameworkCore.Design: from 5.0.0 to 5.0.0
- Microsoft.EntityFrameworkCore.InMemory: from 5.0.0 to 5.0.0
- Microsoft.EntityFrameworkCore.Relational: from 5.0.0 to 5.0.0
- Microsoft.EntityFrameworkCore.Sqlite: from 5.0.0 to 5.0.0
- Microsoft.EntityFrameworkCore.SqlServer: from 5.0.0 to 5.0.0

…023.2 Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer From Version 5.0.0 -> To Version 5.0.0

ghost

Auto-approving dependency update.

…023.3 Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer From Version 5.0.0 -> To Version 5.0.0

mmitche · 2020-10-26T14:17:07Z

@dougbu @ajcvickers These seem to be failing pretty consistently with efcore's newest fixes. Can you take a look?

Pilchie · 2020-10-26T18:27:13Z

Tagging @pranavkm too. I can't see how this failure is related to an EF update.

ajcvickers · 2020-10-26T18:35:27Z

@Pilchie @pranavkm @dougbu Agreed that I don't see any way the EF changes could cause these failures.

/cc @bricelam

dougbu · 2020-10-26T18:53:59Z

That test class references the BasicTestApp project but the containing project uses the Wasm.Authentication.Server. In turn, that project references

Microsoft.AspNetCore.Identity.EntityFrameworkCore
Microsoft.EntityFrameworkCore.Design
Microsoft.EntityFrameworkCore.Relational
Microsoft.EntityFrameworkCore.SQLite

@captainsafia @pranavkm is the Wasm.Authentication.Server involved in this particular test❔

dougbu · 2020-10-26T18:54:44Z

Loads 'o details:

OpenQA.Selenium.BrowserAssertFailedException : Xunit.Sdk.EqualException: Assert.Equal() Failure
Expected: 1
Actual:   0
   at Xunit.Assert.Equal[T](T expected, T actual, IEqualityComparer1 comparer) in C:\\Dev\\xunit\\xunit\\src\\xunit.assert\\Asserts\\EqualityAsserts.cs:line 40
 at Microsoft.AspNetCore.E2ETesting.WaitAssert.<>c__DisplayClass17_0.<WaitAssertCore>b__0() in /_/src/Shared/E2ETesting/WaitAssert.cs:line 83
 at Microsoft.AspNetCore.E2ETesting.WaitAssert.<>c__DisplayClass18_01.<WaitAssertCore>b__0(IWebDriver ) in //src/Shared/E2ETesting/WaitAssert.cs:line 109
Screen shot captured at 'F:\workspace\_work\1\s\artifacts\TestResults\Release\Microsoft.AspNetCore.Components.E2ETests\ddfaaf007f3a4369a538b638f589f3a0.png'
Page content:
<head>
    <meta charset="utf-8">
    <title>Basic test app</title>
    <base href="/subdir/">
    <link href="style.css" rel="stylesheet">
    <link rel="icon" href="data:,">

    
    <link href="_content/TestContentPackage/styles.css" rel="stylesheet">

    
    <link href="BasicTestApp.styles.css" rel="stylesheet">
</head>

<body>
    <root><div id="test-selector">
    Select test:
    <select id="test-selector-select"><option value="none">Choose...
        <option value="BasicTestApp.AfterRenderInteropComponent">After-render interop component
        <option value="BasicTestApp.AuthTest.AuthRouter">Auth cases
        <option value="BasicTestApp.BindCasesComponent">bind cases
        <option value="BasicTestApp.ComponentRefComponent">Component ref component
        <option value="BasicTestApp.ConfigurationComponent">Configuration
        <option value="BasicTestApp.CounterComponent">Counter
        <option value="BasicTestApp.CounterComponentWrapper">Counter wrapped in parent
        <option value="BasicTestApp.DataDashComponent">data-* attribute rendering
        <option value="BasicTestApp.DuplicateAttributesComponent">Duplicate attributes
        <option value="BasicTestApp.ElementRefComponent">Element ref component
        <option value="BasicTestApp.EventBubblingComponent">Event bubbling
        <option value="BasicTestApp.EventCasesComponent">Event cases


Stack trace
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.WaitAssertCore[TResult](IWebDriver driver, Func`1 assertion, TimeSpan timeout) in /_/src/Shared/E2ETesting/WaitAssert.cs:line 139
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.WaitAssertCore(IWebDriver driver, Action assertion, TimeSpan timeout) in /_/src/Shared/E2ETesting/WaitAssert.cs:line 84
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.Equal[T](IWebDriver driver, T expected, Func`1 actual) in /_/src/Shared/E2ETesting/WaitAssert.cs:line 27
   at Microsoft.AspNetCore.Components.E2ETest.Tests.VirtualizationTest.CancelsOutdatedRefreshes_Async() in /_/src/Components/test/E2ETest/Tests/VirtualizationTest.cs:line 189
----- Inner Stack Trace -----
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.<>c__DisplayClass17_0.<WaitAssertCore>b__0() in /_/src/Shared/E2ETesting/WaitAssert.cs:line 83
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.<>c__DisplayClass18_0`1.<WaitAssertCore>b__0(IWebDriver _) in /_/src/Shared/E2ETesting/WaitAssert.cs:line 109

pranavkm · 2020-10-26T19:14:26Z

Looking.

pranavkm · 2020-10-26T20:28:48Z

This appears to be a flaky test. I can reproduce the failures with some inconsistency, so the right call here would be to quarantine it and go from there. Related, when testing locally, I see our test fixture report issues with Kestrel:

System.InvalidOperationException : Memory pool with active blocks is being disposed, 1051 of 1057 returned
  Stack Trace:
     at System.Buffers.MemoryPoolThrowHelper.ThrowInvalidOperationException_DisposingPoolWithActiveBlocks(Int32 returned, Int32 total, DiagnosticPoolBlock[] blocks) in D:\work\50\src\Shared\Buffers.MemoryPool\MemoryPoolThrowHelper.cs:line 62
   at System.Buffers.DiagnosticMemoryPool.Dispose(Boolean disposing) in D:\work\50\src\Shared\Buffers.MemoryPool\DiagnosticMemoryPool.cs:line 119
   at System.Buffers.MemoryPool`1.Dispose()
   at Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.SocketConnectionListener.DisposeAsync() in D:\work\50\src\Servers\Kestrel\Transport.Sockets\src\SocketConnectionListener.cs:line 169
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.TransportManager.GenericConnectionListener.DisposeAsync() in D:\work\50\src\Servers\Kestrel\Core\src\Internal\Infrastructure\TransportManager.cs:line 172
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.TransportManager.ActiveTransport.DisposeAsync() in D:\work\50\src\Servers\Kestrel\Core\src\Internal\Infrastructure\TransportManager.cs:line 150
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure.TransportManager.StopTransportsAsync(List`1 transportsToStop, CancellationToken cancellationToken) in D:\work\50\src\Servers\Kestrel\Core\src\Internal\Infrastructure\TransportManager.cs:line 115
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.StopAsync(CancellationToken cancellationToken) in D:\work\50\src\Servers\Kestrel\Core\src\Internal\KestrelServerImpl.cs:line 237
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.Dispose() in D:\work\50\src\Servers\Kestrel\Core\src\Internal\KestrelServerImpl.cs:line 258
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.DisposeAsync()
--- End of stack trace from previous location ---
   at Microsoft.Extensions.Hosting.Internal.Host.DisposeAsync()
   at Microsoft.Extensions.Hosting.Internal.Host.Dispose()
   at Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures.WebHostServerFixture.Dispose() in D:\work\50\src\Components\test\E2ETest\Infrastructure\ServerFixtures\WebHostServerFixture.cs:line 30
   at Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures.ToggleExecutionModeServerFixture`1.Dispose() in D:\work\50\src\Components\test\E2ETest\Infrastructure\ServerFixtures\ToggleExecutionModeServerFixture.cs:line 62

@halter73 \ @Tratcher do you know what might cause this? I can't say I've seen this error before today.

Tratcher · 2020-10-26T20:32:31Z

@pranavkm that's usually a secondary issue caused by ungraceful shutdown. E.g. It's trying to shut down the host/server while requests are still in flight, probably because of a timeout. From the logs does it look like it's timing out?

dougbu · 2020-10-26T20:43:46Z

This appears to be a flaky test.

Was it flaky in release/5.0 before getting the latest EF bits❔ If yes, let's get the tests quarantined in this PR.

pranavkm · 2020-10-26T20:47:45Z

@dougbu the code path being tested does not use EF at all - it's purely component based code. I'm not worried about the dependency update affecting this test. Trying this out in master, it failed in a similar fashion 1/7 runs.

@Tratcher \ @halter73 unfortunately we do not have server logs for these tests (and it's hard to improvise one with the way they're authored).

halter73 · 2020-10-26T20:48:35Z

Memory pool with active blocks is being disposed, 1051 of 1057 returned

I agree with @Tratcher that the most likely cause is ungraceful shutdown. Server logs would make it clear if this is what's happening. Another possibility is that there's something reading/writing request/response data that isn't being properly awaited.

dougbu · 2020-10-26T20:52:46Z

the code path being tested does not use EF at all

🆗 then who has the action item to do the quarantining❔ Let's do this quickly…

pranavkm · 2020-10-26T20:59:51Z

Updated this PR to include the quarantine.

dotnet-maestro Bot requested a review from dougbu as a code owner October 24, 2020 06:19

ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Oct 24, 2020

ghost approved these changes Oct 24, 2020

View reviewed changes

ghost added the tell-mode Indicates a PR which is being merged during tell-mode label Oct 24, 2020

Quarantine flaky test

9c4243a

dotnet-maestro Bot requested review from a team and SteveSandersonMS as code owners October 26, 2020 20:59

dotnet-maestro Bot merged commit 371a26f into release/5.0 Oct 26, 2020

dotnet-maestro Bot deleted the darc-release/5.0-0a32fb97-88c2-4b71-a3ff-a2b5389fbcac branch October 26, 2020 22:25

Conversation

dotnet-maestro Bot commented Oct 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/efcore

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

mmitche commented Oct 26, 2020

Uh oh!

Pilchie commented Oct 26, 2020

Uh oh!

ajcvickers commented Oct 26, 2020

Uh oh!

dougbu commented Oct 26, 2020

Uh oh!

dougbu commented Oct 26, 2020

Uh oh!

pranavkm commented Oct 26, 2020

Uh oh!

pranavkm commented Oct 26, 2020

Uh oh!

Tratcher commented Oct 26, 2020

Uh oh!

dougbu commented Oct 26, 2020

Uh oh!

pranavkm commented Oct 26, 2020

Uh oh!

halter73 commented Oct 26, 2020

Uh oh!

dougbu commented Oct 26, 2020

Uh oh!

pranavkm commented Oct 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dotnet-maestro Bot commented Oct 24, 2020 •

edited

Loading