Skip to content

Revert "Make build targets extendable (#2080)" - #4148

Merged
ViktorHofer merged 3 commits into
dotnet:masterfrom
ViktorHofer:SolutionBuildTargetsHack
Oct 17, 2019
Merged

Revert "Make build targets extendable (#2080)"#4148
ViktorHofer merged 3 commits into
dotnet:masterfrom
ViktorHofer:SolutionBuildTargetsHack

Conversation

@ViktorHofer

Copy link
Copy Markdown
Member

This reverts commit e5b1517.
Fixes #2116

cc @markwilkie

We don't need that undocumented extensibility point anymore in corefx.

@ViktorHofer
ViktorHofer requested a review from tmat October 17, 2019 18:05
@ViktorHofer ViktorHofer self-assigned this Oct 17, 2019
Comment thread src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj Outdated
Comment thread src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj
@tmat

tmat commented Oct 17, 2019

Copy link
Copy Markdown
Member

Thanks for cleaning this up!

@ViktorHofer
ViktorHofer merged commit 734ec96 into dotnet:master Oct 17, 2019
@ViktorHofer
ViktorHofer deleted the SolutionBuildTargetsHack branch October 17, 2019 19:36
@markwilkie

Copy link
Copy Markdown
Contributor

Thanks @ViktorHofer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review build.proj extensibility changes

3 participants