Pass nocolor to xunit if archived#2114
Merged
Merged
Conversation
wfurt
approved these changes
Feb 26, 2019
wfurt
left a comment
wfurt
left a comment
Member
There was a problem hiding this comment.
thanks @ViktorHofer . I assume the ArchiveTests is not set during "normal" test run by developer, right?
Member
Author
|
Correct. |
safern
reviewed
Feb 26, 2019
| <TestAssembly Condition="'$(TestAssembly)' == ''">$(TargetFileName)</TestAssembly> | ||
| <TestPath Condition="'$(TestPath)' == ''">$(OutDir)</TestPath> | ||
| <RunWorkingDirectory>$(TestPath)</RunWorkingDirectory> | ||
| <ArchiveTest Condition="'$(ArchiveTests.ToLower())' == 'all' OR $(MSBuildProjectName.EndsWith('.$(ArchiveTests)'))"></ArchiveTest> |
Member
There was a problem hiding this comment.
Maybe I'm confused here, why are you setting this to empty, and then using ArchiveTest as a boolean?
Member
Author
There was a problem hiding this comment.
lol => should be true.
Member
Author
There was a problem hiding this comment.
Thanks!!!!!!!!!!!!!!!! 🗡
safern
approved these changes
Feb 26, 2019
This was referenced Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/arcade/issues/2098
cc @wfurt