Don't specify a results container unless explicitly provided connection string#1991
Merged
Conversation
MattGal
requested changes
Feb 6, 2019
MattGal
left a comment
MattGal
left a comment
Member
There was a problem hiding this comment.
Seems reasonable, but two things:
- Until the next Helix rollout this shouldn't be included or it'll break public jobs
- Users might very well want to still be able to have a connection string for drops and a different one for results, maybe consider plumbing that through?
Contributor
Author
|
@MattGal Both reasonable requests, yeah. I think I'll add a separate connection string for results then. |
Contributor
Author
|
@MattGal, separate connection strings implemented. |
Member
|
@jonfortescue with luck this will be merge-able in the next hour. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alexperovich
approved these changes
Feb 21, 2019
This was referenced Aug 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Helix API can automatically create results containers in the proper place if we don't specify one, so we should let it do that.