Skip to content

Improve error handling when a key is missing#14002

Merged
mmitche merged 2 commits into
mainfrom
better-error
Aug 31, 2023
Merged

Improve error handling when a key is missing#14002
mmitche merged 2 commits into
mainfrom
better-error

Conversation

@lewing

@lewing lewing commented Aug 30, 2023

Copy link
Copy Markdown
Member

This pr is to avoid

.packages\microsoft.dotnet.arcade.sdk\8.0.0-beta.23428.2\tools\InstallDotNetCore.targets(15,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) The "InstallDotNetCore" task failed unexpectedly.
System.InvalidOperationException: Sequence contains no elements
   at System.Linq.ThrowHelper.ThrowNoElementsException()
   at System.Linq.Enumerable.First[TSource](IEnumerable`1 source)
   at Microsoft.DotNet.Arcade.Sdk.InstallDotNetCore.Execute() in /_/src/Microsoft.DotNet.Arcade.Sdk/src/InstallDotNetCore.cs:line 110
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)

when the property doesn't exist.

cc @mmitche

@lewing lewing requested review from hoyosjs, joeloff, mcumming and mmitche and removed request for mcumming August 30, 2023 22:02
@mmitche mmitche merged commit ec030fd into main Aug 31, 2023
@lewing lewing deleted the better-error branch August 31, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants