Add --no-gpg-sign to codeflow git commits#6382
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix temporary commits to disable gpg signing
Add --no-gpg-sign to codeflow git commits
Jun 10, 2026
premun
approved these changes
Jun 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates DARC’s VMR/codeflow-related git commit invocations to explicitly disable GPG signing (--no-gpg-sign), preventing interactive signing/passphrase prompts during temporary/local commits that can interrupt darc vmr workflows.
Changes:
- Add
--no-gpg-signtoLocalGitClient.CommitAsyncargument construction. - Add
--no-gpg-signtoLocalGitClient.CommitAmendAsync. - Add
--no-gpg-signto the remaining directgit commitinvocation inRemoteRepoBase.CommitFilesAsync.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Microsoft.DotNet.Darc/DarcLib/RemoteRepoBase.cs | Disables GPG signing for commit created during remote repo file commit/push flow. |
| src/Microsoft.DotNet.Darc/DarcLib/LocalGitClient.cs | Disables GPG signing for standard and amend commit paths used by VMR/codeflow operations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
darc vmrcommands (e.g.resolve-conflict) make temporary local commits during codeflow. Users with GPG signing enabled globally get interrupted by signing-password prompts mid-operation.All codeflow commits route through a small set of central git commit invocations, each now passes
--no-gpg-sign:LocalGitClient.CommitAsync— primary commit path used by all Vmr flowers and conflict resolvers (VmrManagerBase,WorkBranch,VmrBackFlower,CodeFlowConflictResolver,VmrCodeflower).LocalGitClient.CommitAmendAsync— amend commits.RemoteRepoBase— the remaining directgit commitin the PR-creation path.Merge/rebase steps in
WorkBranchuse--no-commit/--squashand finalize viaCommitAsync, so they're covered by the central change.#6266