Skip to content

Add notes for JSON reference handling#109

Merged
terrajobst merged 2 commits into
dotnet:masterfrom
terrajobst:json-reference-handling
Dec 6, 2019
Merged

Add notes for JSON reference handling#109
terrajobst merged 2 commits into
dotnet:masterfrom
terrajobst:json-reference-handling

Conversation

@terrajobst

Copy link
Copy Markdown
Contributor

No description provided.

@terrajobst terrajobst requested a review from a team December 3, 2019 22:55
@GrabYourPitchforks

Copy link
Copy Markdown
Member

That seems to have fairly captured the conversation. Engineering team may want to clarify a bit what it meant by "escape the $". I'll also work on some docs detailing potential security risks of enabling this feature and how to use it safely / successfully inside your own app.

@jozkee

jozkee commented Dec 6, 2019

Copy link
Copy Markdown
Member

This is what I understand from "Escape the $":

  • On serialization, when a JSON property name, that is either a dictionary key or a CLR class property, starts with a '$' character, we must write the escaped character "\u0024" instead.

  • On deserialization, metadata will be digested by using only the raw bytes, so no encoded characters are allowed in metadata; to read JSON properties that start with a '$' you will need to pass it with the escaped '$' (\u0024).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants