Skip to content

Audit remaining unported Classic test suites #7906

Closed as not planned
Closed as not planned

Description

@jpobst

We are removing "Classic" Xamarin.Android code from the main branch. "Classic" will continue to be maintained for the remainder of its supported lifetime out of existing branch(es). (Currently d17-5)

The following test suites do not currently have .NET equivalents. We need to determine if they should be ported to .NET or if they are no longer relevant and can be removed.

  • Xamarin.Android.JcwGen-Tests.csproj
  • Xamarin.Android.JcwGen-Tests.csproj /p:AndroidFastDeploymentType=Assemblies:Dexes
  • Xamarin.Android.Locale-Tests.csproj
  • Xamarin.Android.Locale-Tests.csproj /p:AotAssemblies=True
  • Xamarin.Android.Locale-Tests.csproj /p:AotAssemblies=True /p:AndroidEnableProfiledAot=true
  • EmbeddedDSO.csproj
  • Xamarin.Forms.Performance.Integration.Droid.csproj
  • Xamarin.Forms.Performance.Integration.Droid.csproj /p:AotAssemblies=true
  • Xamarin.Forms.Performance.Integration.Droid.csproj /p:AotAssemblies=True /p:AndroidEnableProfiledAot=true
  • VSAndroidAppProxy.csproj
  • Xamarin.Android.Bcl-Tests.csproj

Activity

  1. ghost added
    needs-triageIssues that need to be assigned.
    on Mar 21, 2023
  2. added and removed
    needs-triageIssues that need to be assigned.
    on Mar 21, 2023
  3. jonpryor commented on Mar 23, 2023

    @jonpryor
    Contributor

    @dellis1972: is there a need for tests/locales/Xamarin.Android.Locale-Tests*.csproj? We have existing localization tests which appear to run under .NET 7+, e.g. PR #6693, so are these projects duplciative?

  4. jonpryor commented on Mar 23, 2023

    @jonpryor
    Contributor

    @steveisok: do we want to run the dotnet/runtime BCL tests in a .NET Android environment? Or is that not a huge concern?

    If it is a concern, what's the "sanest" way to do that?

  5. dellis1972 commented on Mar 23, 2023

    @dellis1972
    Contributor

    @dellis1972: is there a need for tests/locales/Xamarin.Android.Locale-Tests*.csproj? We have existing localization tests which appear to run under .NET 7+, e.g. PR #6693, so are these projects duplciative?

    Looks like there might be some tests in there we should port to the more comprehensive tests we have in #6693, e.g the Environment tests and the Globalisation checks.

  6. added this to the .NET 9 milestone on Dec 12, 2023
  7. jpobst commented on May 17, 2024

    @jpobst
    ContributorAuthor

    If we aren't running them by now, they must not be important. ;)

    Closing.

  8. locked and limited conversation to collaborators on Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: Unit TestsIssues with repo unit tests.enhancementProposed change to current functionality.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions