Sync ref project references with runtime projects#2878
Merged
Conversation
This should enable ResolveAssemblyReferences to generate the correct binding redirects.
benrr101
approved these changes
Nov 1, 2024
benrr101
left a comment
benrr101
left a comment
Contributor
There was a problem hiding this comment.
This change seems pretty reasonable to me. Let's get the merge conflicts fixed and make sure the test runs pass and we'll get it merged. Thanks for looking into this!
Contributor
Author
|
Thanks @benrr101 - just merged! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2878 +/- ##
==========================================
- Coverage 72.31% 72.31% -0.01%
==========================================
Files 288 288
Lines 59660 59660
==========================================
- Hits 43146 43144 -2
- Misses 16514 16516 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mdaigle
approved these changes
Nov 7, 2024
cheenamalhotra
approved these changes
Nov 7, 2024
mdaigle
added
the
Code Health 💊
Contributor
Author
|
@cheenamalhotra can I port this back to the next releases of 5.1 and 5.2? This should let us close #2541 for the remaining supported versions. |
Member
|
Sure, that makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR syncs the references of the reference assemblies with those of their respective runtime assemblies. Doing so enables MSBuild's ResolveAssemblyReferences and GenerateBindingRedirects targets to generate the correct binding redirects - so if a downstream library references a later version of Azure.Core or Azure.Identity, VS will generate binding redirects so that SqlClient will use that later version.
Early testing looks promising and I think it'll resolve the issue - but for now, it just relates to #2541 and to #2082.