Performance improvements#745
Open
justinswork wants to merge 2 commits intodotnet:masterfrom
Open
Conversation
justinswork
force-pushed
the
perf-improvements
branch
from
46d6d33 to
24d423a
Compare
tom-englert
requested changes
Apr 6, 2026
tom-englert
requested changes
Apr 6, 2026
justinswork
force-pushed
the
perf-improvements
branch
2 times, most recently
from
76ed303 to
7eb220a
Compare
tom-englert
requested changes
Apr 20, 2026
| public bool IsLoading { get; private set; } | ||
|
|
||
| // Do not use CollectionViewSource in XAML, has huge performance impact when there are many items in the list. | ||
| public CollectionView GroupedResourceTableEntries |
Collaborator
There was a problem hiding this comment.
This property is only used by binding, and no one ever raises a property change event for this, so it is accessed only once, so this "optimization" has absolutely no effect
Contributor
Author
There was a problem hiding this comment.
Right. The comment above the property is what caught my eye, and I assumed this would still be considered an improvement, as the collection view itself only needs to be created once, even if it was accessed multiple times, but you're right, it doesn't make any impact right now. I can pull out this commit
justinswork
force-pushed
the
perf-improvements
branch
from
7eb220a to
7018864
Compare
justinswork
force-pushed
the
perf-improvements
branch
from
7018864 to
1d55d7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had to dig in and see if there was any low-hanging fruit that could dramatically improve performance, as it seems to be quite slow when loading hundreds of RESX files.