Skip to content

feat(actions): add nuget trusted publishing & fix duplicated permission declaration - #908

Merged
AArnott merged 1 commit into
dotnet:mainfrom
micheloliveira-com:feature/nuget-trusted-publishing
Oct 2, 2025
Merged

AArnott merged 1 commit into
dotnet:mainfrom
micheloliveira-com:feature/nuget-trusted-publishing

Conversation

@micheloliveira-com

Copy link
Copy Markdown
Contributor

Motivation

As described in the official announcement, the new Trusted Publishing feature greatly enhances package publishing security on NuGet.org.

We successfully tested this approach with our own NuGet library:

Required changes in this repository

Recommendation followed from announcement:
For security, always use a GitHub secret like ${{ secrets.NUGET_USER }} for your NuGet.org username (profile name), not your email address.

  • Add secrets.NUGET_USER to this repository, using the NuGet.org username (profile name) of the package owner (Nerdbank in this case).
  • The old secrets. NUGET_API_KEY secret can be removed from this repository and also from the NuGet.org account if it was only used here.

One-time configuration on NuGet.org

According to the documentation:

  1. Sign in to NuGet.org.
  2. Open your user menu (top-right) → Trusted Publishing (next to “API Keys”).
  3. Create a policy:
    • Package owner: you or your organization (e.g. Nerdbank).
    • Repository owner: your GitHub org/user (e.g. dotnet).
    • Repository name: repository name (e.g. Nerdbank.Streams).
    • Workflow file: the YAML file under .github/workflows/ (e.g. release.yml).
    • Environment (optional): specify if your workflow uses GitHub Actions environments.

This setup eliminates the need for long-lived API keys and improves the overall security of the publishing process.

I also fixed it as it looks duplicated:

  • Before:
    permissions:
      id-token: write
    permissions:
      actions: read
      contents: write
  • After:
    permissions:
      id-token: write
      actions: read
      contents: write

@micheloliveira-com

Copy link
Copy Markdown
Contributor Author

Note: I think leaving NuGet/login without a SHA hash is fine since it's an official Microsoft action.

  • Forcing a SHA might break in future core NuGet changes..

@AArnott AArnott left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AArnott
AArnott enabled auto-merge September 27, 2025 14:51
@micheloliveira-com

Copy link
Copy Markdown
Contributor Author

@AArnott Hello!

It looks like a pipeline rerun is needed to finish this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants