[11.0 P5] Blazor Preview 5 updates#37206
Conversation
There was a problem hiding this comment.
Pull request overview
Adds .NET 11 Preview 5 QuickGrid SSR/URL-based navigation coverage to the QuickGrid reference article (under >= aspnetcore-11.0 monikers) and stages release-notes content (currently HTML-commented) for Preview 5 release day.
Changes:
- Adds new 11.0-monikered sections to
quickgrid.mdcovering URL-based pagination, multiple grids on the same page, title-based sort identification, and theEnableUrlBasedQuickGridNavigationAndSortingAppContext switch. - Reworks moniker fencing around existing "Sort by column," "Page items," and "Open and return from a details page" sections so legacy guidance remains for
< aspnetcore-11.0. - Drafts a (commented-out) Preview 5 release-notes blurb in
aspnetcore-11/includes/blazor.mdsummarizing the same QuickGrid changes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| aspnetcore/blazor/components/quickgrid.md | Adds 11.0 reference coverage for URL-based navigation, multi-grid prefixes, sort/title behavior, and AppContext disable switch; restructures monikers. |
| aspnetcore/release-notes/aspnetcore-11/includes/blazor.md | Staged (commented-out) Preview 5 release-notes section for QuickGrid improvements. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@dariatiurina ... I added the I also made updates to the temporary data ( BTW ... This PR is probably going to collect the rest of the Blazor Preview 5 coverage. It will sit until release next Tuesday. |
dariatiurina
left a comment
There was a problem hiding this comment.
Thank you for your work! Here are some notes:
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@wadepickett ... I think this 🐘 PR is ready now. I didn't change the Release Notes article date on this PR, so it's relying on being merged before #37241. |
| }.AsQueryable(); | ||
|
|
||
| [SupplyParameterFromQuery] | ||
| private int Page { get; set; } |
There was a problem hiding this comment.
I realize this is outside of the PR scope, but I'll mention. Since we are checknig if Page even has a value, should it be declared nullable" int? Page
There was a problem hiding this comment.
I can address this, but it will need to be in like 30 minutes. If you want, I can patch it on a patch PR. Otherwise, we just need to wait another 30 minutes. I have a prior (quick) family obligation that I can't get out of.
There was a problem hiding this comment.
Patch after is fine. Alerady approved. Up to you.
There was a problem hiding this comment.
My recollection is just that it goes to zero if not present in this case. There are a few examples that I need to look at, however, to make sure that they're all addressing this the same way. We might also need to make a remark about behavioral difference between nullable and non-nullable.
Yeah ... I recommend let's go ahead and merge this now. I'm going to run over and take care of the family situation. I'll be back soon and ping you probably in like an hour or so with a PR on this.
There was a problem hiding this comment.
I'll also add the NavigationManager to the earlier example.
Sorry for the poor timing! I'll get your feedback resolved as soon as I get back to the house. 🏃♂️🏃♂️🏃♂️🏃♂️
wadepickett
left a comment
There was a problem hiding this comment.
Approved. See the questions I had inline though.
Fixes #37102
Fixes #37219
Fixes #37233
Fixes #37234
Daria ...
QueryParameterNamePrefixandGetPageUrl. Is there more API to call out?[SupplyParameterFromSession]coverage.Internal previews
Toggle expand/collapse