Conversation
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Member
|
So now all routes that return a collection will have their own handler ? @alexmerlin |
Member
Author
Yes, all collection routes with their own handler that's sole purpose is to have a get method that returns the requested collection. This PR is not a final solution (unless accepted), but to me it looked to be the simplest and most straightforward one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation removes the dependency of
configfrom all handlers.It also introduces new handlers for collection related endpoints.
@cPintiuta @MarioRadu let me know your thoughts, if this implementation solves the issue described in #313 or I should look into other solutions.