Skip to content

Feature requests #20

Closed
Closed

Description

@Matsv

Hello,

I had some features in mind that could be useful

  • Submenu's
  • Possibility to add empty lines to keep things organized / to add non-clickable texts.

Thanks for making this library, it's really helpful because the default looks like windows 2003 on Linux 😄

Activity

  1. self-assigned this
    on May 2, 2016
  2. dorkbox commented on May 2, 2016

    @dorkbox
    Owner

    You're welcome!

    Those are some good ideas which I have personally thought about adding as well. Maybe even an actual "line" is possible?

    Time is always the enemy on public projects; I have a very full schedule, and before I do these things I need to finish up some work on the MBassador project, so it will be a little while before they are implemented.

    If you wanted to contribute something (something simple and easy if fine with me), I'd happily add it.

  3. Matsv commented on May 2, 2016

    @Matsv
    Author

    I'll try to work on it when I have time. The only thing is, I don't have a Windows workspace set up at the moment. What libraries do you use?

    EDIT I see you are using dorkboxUtil_v1.0.jar in your iml, is there some way to get that? 😄

  4. dorkbox commented on May 3, 2016

    @dorkbox
    Owner

    JNA is the only thing you'll need, but it is only necessary for Linux since Windows/Mac use the "Java" default one with a custom popup-menu, which is just a JPopupMenu.

  5. jechaviz commented on Jun 2, 2016

    @jechaviz

    Is there a way you could add support for simple tooltip? Anything like systemTray.info("Message"); systemTray.warning("Message"); systemTray.error("Message"); using the native os tooltip or notification system (or at least for windows)?
    Thank you in advance.

  6. dorkbox commented on Jun 2, 2016

    @dorkbox
    Owner

    @jechaviz you can also use the Notify project to display notifications next to the system tray. They are not attached to anything in particular so you can place them anywhere you like. It's not exactly the same thing as a system tray tooltip, but it's the closest one can get given the restrictions on system tray events.

  7. tresf commented on Sep 13, 2016

    @tresf

    Windows/Mac use the "Java" default one with a custom popup-menu, which is just a JPopupMenu.

    FYI, I've had a lot of problems with the JPopupMenu on Mac, so I actually wrote a small AWT wrapper with a recursive MenuItem function. AWT looks perfect on Mac, just suffers the dead right-click bug.

  8. dorkbox commented on Sep 26, 2016

    @dorkbox
    Owner

    Nice! Would you be able to see if the 3.0 beta (available in issue #22) works the way it should? Also, I have "baked in" configurations for testing, and auto-detect should always work the way you want, but... can you also see what happens with the GtkStatusIcon version (does it suffer from the dead right-click bug?)

  9. tresf commented on Sep 26, 2016

    @tresf

    Nice! Would you be able to see if the 3.0 beta (available in issue #22) works the way it should? Also, I have "baked in" configurations for testing, and auto-detect should always work the way you want, but...

    In my tests against SystemTray_autodetect/SystemTray_normal.jar + MacOS 10.11 (El Capitan)

    • ✅ PASS.
    • Both left click as well as right click work flawlessly.
    • The menu does not hang, it does not linger behind after the mouse have been moved off of it.
      screen shot 2016-09-25 at 10 38 22 pm

    Furthermore, tests against SystemTray_autodetect/SystemTray_normal.jar + MacOS 10.7 (Lion):

    • ✅ PASS. They are identical to above.
      screen shot 2016-09-25 at 10 49 19 pm

    can you also see what happens with the GtkStatusIcon version (does it suffer from the dead right-click bug?)

    Test results for SystemTray_forceGtkStatusIcon/SystemTray_normal.jar + MacOS 10.11 (El Capitan)

    • ✅ PASS. They are also identical to above.
  10. dorkbox commented on Sep 26, 2016

    @dorkbox
    Owner

    Awesome, thank you for testing this!

  11. dorkbox commented on Sep 26, 2016

    @dorkbox
    Owner

    Any possibility you can also verify the javaFX and SWT versions?

    EDIT: just the "normal" test is sufficient.

  12. tresf commented on Sep 26, 2016

    @tresf

    Windows 10 x64 looks good with exception of the large icon size when run on hi-dpi display.

    image

    Off-topic, but how did you fix the actual tray icon scaling? JNI?

    Any possibility you can also verify the javaFX and SWT versions?
    EDIT: just the "normal" test is sufficient.

    Sure however I find these statements to be contradictory. Can you please be more specific?

    You have the following unit tests:

    SystemTray_autodetect/  
        SystemTray_javaFX.jar
        SystemTray_normal.jar   
        SystemTray_swt.jar  
    SystemTray_forceAppIndicator/
        SystemTray_javaFX.jar
        SystemTray_normal.jar   
        SystemTray_swt.jar  
    SystemTray_forceGtkStatusIcon/
        SystemTray_javaFX.jar
        SystemTray_normal.jar   
        SystemTray_swt.jar  
    SystemTray_forceSwing/
        SystemTray_javaFX.jar
        SystemTray_normal.jar   
        SystemTray_swt.jar  
    
  13. dorkbox commented on Sep 26, 2016

    @dorkbox
    Owner

    by "normal", i meant just using the autoDdetect directory --- sorry for the confusion.

    As per fixing the scaling issue on windows, that was a tricky deal. I'm doing in-memory bytecode modification of the windows tray class at runtime and then injecting it into the bootstrap classloader.
    EDIT: I'm using JNA to perform the bytecode injection.

  14. dorkbox commented on Sep 26, 2016

    @dorkbox
    Owner

    I'll fix the menu icon size... whoops! I forgot windows doesn't auto-scale those.

  15. dorkbox commented on Oct 5, 2016

    @dorkbox
    Owner

    Submenu's and separators have been added to beta 3.0. Please see the (oldest) entry for appropriate beta jars for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions