docs: note stricter windows filename detection in the migration guide - #70
Merged
Conversation
1.x classified any filename containing 'win' as a windows asset; 2.0 only recognizes win32/win64 markers and the windows-specific extensions. Operators shipping bare -win/-windows portable archives need to rename them, so call the change out in the migration guide. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AtqCsX7ptP36t5rdyaJJhM
There was a problem hiding this comment.
Pull request overview
Updates the 2.0 migration guide to document an intentional behavior change in how Pecans classifies Windows assets from release filenames, helping operators avoid “missing Windows build” surprises after upgrading.
Changes:
- Adds a migration note that 2.0 no longer treats bare
win/windowstokens in archive names as Windows assets. - Clarifies the accepted Windows markers (
win32/win64) and Windows-specific extensions (.exe,.nupkg,.msix,.msixbundle), with concrete filename examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents an intentional 2.0 behavior change in the migration guide's "Behavior changes" section: 1.x classified any filename containing
winas a Windows asset; 2.0 only recognizeswin32/win64markers and the Windows-specific extensions (.exe/.nupkg/.msix/.msixbundle). Bare-win/-windowsportable archives (e.g.MyApp-1.0.0-win.zip) are skipped at ingestion, so operators need to include an explicitwin32/win64marker in artifact names.From the 2.0 release review pass.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AtqCsX7ptP36t5rdyaJJhM
Generated by Claude Code