chore(deps): update dev dependencies and remove unused ones - #51
Merged
Conversation
- Bump vitest, @vitest/ui, @vitest/coverage-v8 3.2 -> 4.1 - Bump semantic-release 21 -> 25, @semantic-release/changelog 6 -> 7, @semantic-release/git 10 -> 11 - Bump @types/supertest 6 -> 7, nanoid 3 -> 6 - Patch/minor bumps: @types/debug, @types/semver, eslint, prettier, tsx, typescript (5.9.3), typescript-eslint - Remove unused devDependencies: sinon, @types/destroy - Adapt tests to vitest 4: class-based constructor mocks and explicitly typed vi.fn() signatures TypeScript intentionally kept on 5.9.x; 7.x is not yet supported by typescript-eslint. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018qeKKb7HKWWM9E9iTh4JGk
There was a problem hiding this comment.
Pull request overview
This PR updates and prunes devDependencies (no production dependency changes), regenerates the lockfile to clear npm audit, and adjusts a couple unit tests to accommodate Vitest 4’s stricter mocking/typing behavior.
Changes:
- Bump major dev tooling: Vitest 4.x, semantic-release 25.x, nanoid 6.x, plus assorted minor/patch updates.
- Remove unused devDependencies (
sinon,@types/destroy). - Update unit tests for Vitest 4 constructor-mocking and stricter
vi.fn()typing.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/unit/github.spec.ts | Updates Octokit/Webhooks constructor mocks for Vitest 4. |
| test/unit/backend-complete.spec.ts | Adds explicit Vitest mock call signatures to satisfy Express Response typing. |
| package.json | Updates/removes devDependencies only. |
- Restore console spies in afterEach so they don't leak across test files - Give mockRes.json a return value consistent with the express Response chaining contract Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018qeKKb7HKWWM9E9iTh4JGk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviews and updates all outdated dependencies. All production dependencies were already current — every change here is a devDependency.
npm auditis now clean (0 vulnerabilities, down from 5).Major bumps
customAlphabetis used)Minor/patch bumps
@types/debug, @types/semver, eslint 10.7, prettier, tsx, typescript 5.9.3, typescript-eslint 8.65
Removed (unused)
vimockingdestroypackage is never importedDeliberately held back
Test changes for vitest 4
test/unit/github.spec.ts: constructor mocks (Octokit,Webhooks) rewritten as class-based implementations — vitest 4 disallowsmockReturnValueon mocks invoked withnewtest/unit/backend-complete.spec.ts:vi.fn()mocks given explicit call signatures — untypedvi.fn()no longer satisfies express'sResponsesignaturesSecurity
npm audit fixcleared advisories in braces, lodash-es, micromatch, and picomatch; the lockfile was regenerated. The esbuild advisory resolved itself with the removal of tsup onnext(#50), which this branch is rebased on.Test plan
npm run typecheck— cleannpm run lint— cleannpm run build— clean (tsc emit)npm test— 771/771 passing (withenv.test.shsourced)npm run format:check— cleannpm audit— 0 vulnerabilities🤖 Generated with Claude Code
https://claude.ai/code/session_018qeKKb7HKWWM9E9iTh4JGk
Generated by Claude Code