Improve matching: cameralib signature/return fixes, enemy decl/assign…#111
Open
vinvirile wants to merge 1 commit into
Open
Improve matching: cameralib signature/return fixes, enemy decl/assign…#111vinvirile wants to merge 1 commit into
vinvirile wants to merge 1 commit into
Conversation
…, fireWanwan pragma - cameralib.hpp: Fix CLBCalc2DFPos signature, CLBChaseSpecialDecrease return bool->BOOL - cameralib.cpp: Fix CLBCalc2DFPos signature (missing->98.2%), add CLBConstUpVec global (__sinit missing->100%), fix CLBChaseSpecialDecrease return type (87.5%->100%) - enemy.cpp: Split TPathNode decl/assign in doShortCut (94.7%->96.0%) - fireWanwan.cpp: Add #pragma dont_inline around updateCameraShake/updateRumble for moveObject (73.6%->84.6%)
Mrkol
requested changes
May 27, 2026
| getSaveParam2()->mSLDamageHeight.get()); | ||
| } | ||
|
|
||
| #pragma dont_inline on |
Collaborator
There was a problem hiding this comment.
Nah, don't add these hacks, we want proper fixes with real inlines
| extern f32 SMSGetAnmFrameRate(); // avoid including Application.hpp | ||
|
|
||
| void CLBCalc2DFPos(JGeometry::TVec2<f32>*, const MtxPtr, const MtxPtr, | ||
| void CLBCalc2DFPos(JGeometry::TVec2<f32>*, const f32 (*)[4], const f32 (*)[4], |
Collaborator
There was a problem hiding this comment.
Oh shit, is const MtxPtr a const pointer instead of a pointer to const? Probably add a note then that this is correct and MtxPtr should not be used here
Report for GMSJ01 (3be6108 - 6d23444)📈 Matched code: 31.42% (+0.00%, +156 bytes) ✅ 4 new matches
📈 3 improvements in unmatched items
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, fireWanwan pragma