Perform app building via docker image#103
Merged
Merged
Conversation
Since we're going to generate multiple internal images, using a more clear variable will ease code browsing.
Rather than start an ephemeral container, generate a Dockerfile and execute the build inside that image. This provides the ability to take advantage of docker contexts, allowing for remote builds and builds against different architectures. While the ephemeral container provides native cleanup, building images should be done via the normal image build process so folks can depend on their docker daemon to do right correct thing.
josegonzalez
force-pushed
the
build-in-image
branch
from
451bb80 to
a38643b
Compare
Merged
josegonzalez
added a commit
that referenced
this pull request
Aug 6, 2023
- #48 @dependabot: chore(deps): bump github.com/rs/zerolog from 1.27.0 to 1.28.0 - #51 @dependabot: chore(deps): bump github.com/josegonzalez/cli-skeleton from 0.5.0 to 0.7.0 - #52 @dependabot: chore(deps): bump github.com/BurntSushi/toml from 1.2.0 to 1.2.1 - #54 @dependabot: chore(deps): bump github.com/mitchellh/cli from 1.1.4 to 1.1.5 - #55 @dependabot: chore(deps): bump golang from 1.19.0-buster to 1.19.4-buster - #56 @dependabot: chore(deps): bump certifi from 2021.10.8 to 2022.12.7 in /tests/poetry - #57 @dependabot: chore(deps): bump certifi from 2021.10.8 to 2022.12.7 in /tests/pipenv - #58 @dependabot: chore(deps): bump github.com/mattn/go-isatty from 0.0.14 to 0.0.17 - #59 @josegonzalez: Correct issue where mounted volume has bad permissions for git running in a container - #60 @josegonzalez: Update runner to ubuntu 20.04 - #61 @josegonzalez: Add github-actions to dependabot config - #62 @dependabot: chore(deps): bump actions/upload-artifact from 2 to 3 - #63 @dependabot: chore(deps): bump luizm/action-sh-checker from 0.3.0 to 0.5.0 - #64 @dependabot: chore(deps): bump actions/checkout from 2 to 3 - #65 @dependabot: chore(deps): bump hadolint/hadolint-action from 1.5.0 to 3.0.0 - #66 @dependabot: chore(deps): bump ibiqlik/action-yamllint from 3.0.2 to 3.1.1 - #67 @dependabot: chore(deps): bump github.com/aws/aws-lambda-go from 1.34.1 to 1.36.1 - #68 @dependabot: chore(deps): bump github.com/codeclysm/extract/v3 from 3.0.2 to 3.1.0 - #69 @dependabot: chore(deps): bump golang from 1.19.4-buster to 1.19.5-buster - #70 @dependabot: chore(deps): bump github.com/aws/aws-lambda-go from 1.36.1 to 1.37.0 - #71 @josegonzalez: Drop rpm support - #72 @dependabot: chore(deps): bump hadolint/hadolint-action from 3.0.0 to 3.1.0 - #73 @dependabot: chore(deps): bump github.com/rs/zerolog from 1.28.0 to 1.29.0 - #74 @dependabot: chore(deps): bump ludeeus/action-shellcheck from 1.1.0 to 2.0.0 - #75 @dependabot: chore(deps): bump golang from 1.19.5-buster to 1.20.0-buster - #78 @dependabot: chore(deps): bump luizm/action-sh-checker from 0.5.0 to 0.7.0 - #79 @dependabot: chore(deps): bump github.com/aws/aws-lambda-go from 1.37.0 to 1.38.0 - #80 @dependabot: chore(deps): bump golang from 1.20.0-buster to 1.20.2-buster - #81 @dependabot: chore(deps): bump github.com/mattn/go-isatty from 0.0.17 to 0.0.18 - #83 @dependabot: chore(deps): bump golang from 1.20.2-buster to 1.20.3-buster - #84 @dependabot: chore(deps): bump github.com/aws/aws-lambda-go from 1.38.0 to 1.40.0 - #85 @dependabot: chore(deps): bump github.com/rs/zerolog from 1.29.0 to 1.29.1 - #86 @dependabot: chore(deps): bump golang from 1.20.3-buster to 1.20.4-buster - #87 @dependabot: chore(deps): bump github.com/aws/aws-lambda-go from 1.40.0 to 1.41.0 - #88 @dependabot: chore(deps): bump github.com/mattn/go-isatty from 0.0.18 to 0.0.19 - #89 @dependabot: chore(deps): bump requests from 2.27.1 to 2.31.0 in /tests/pip - #90 @dependabot: chore(deps): bump requests from 2.27.1 to 2.31.0 in /tests/pip-runtime - #91 @dependabot: chore(deps): bump requests from 2.27.1 to 2.31.0 in /tests/hooks - #93 @dependabot: chore(deps): bump requests from 2.27.1 to 2.31.0 in /tests/pipenv - #94 @dependabot: chore(deps): bump github.com/codeclysm/extract/v3 from 3.1.0 to 3.1.1 - #95 @dependabot: chore(deps): bump github.com/josegonzalez/cli-skeleton from 0.7.0 to 0.8.0 - #96 @dependabot: chore(deps): bump github.com/BurntSushi/toml from 1.2.1 to 1.3.0 - #97 @dependabot: chore(deps): bump github.com/BurntSushi/toml from 1.3.0 to 1.3.1 - #98 @dependabot: chore(deps): bump golang from 1.20.4-buster to 1.20.5-buster - #99 @dependabot: chore(deps): bump github.com/BurntSushi/toml from 1.3.1 to 1.3.2 - #100 @dependabot: chore(deps): bump github.com/alexellis/go-execute from 0.5.0 to 0.6.0 - #101 @josegonzalez: Fix docblocks in readme - #102 @josegonzalez: chore: run go mod tidy - #103 @josegonzalez: Perform app building via docker image - #104 @josegonzalez: fix: ensure subprocesses are canceled correctly when the main process is terminated - #105 @dependabot: chore(deps): bump github.com/josegonzalez/cli-skeleton from 0.8.0 to 0.9.0 - #107 @dependabot: chore(deps): bump certifi from 2023.5.7 to 2023.7.22 in /tests/pipenv - #108 @dependabot: chore(deps): bump github.com/rs/zerolog from 1.29.1 to 1.30.0 - #109 @Coffee2CodeNL: Add Bookworm Support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than start an ephemeral container, generate a Dockerfile and execute the build inside that image.
This provides the ability to take advantage of docker contexts, allowing for remote builds and builds against different architectures. While the ephemeral container provides native cleanup, building images should be done via the normal image build process so folks can depend on their docker daemon to do right correct thing.