Make phpdoc comments accurate#261
Merged
Merged
Conversation
greg0ire
commented
Mar 25, 2019
adaamz
suggested changes
Mar 25, 2019
|
I think string is not acceptable for $enum. |
Member
Author
|
Me too :P |
adaamz
suggested changes
Mar 25, 2019
adaamz
previously approved these changes
Mar 26, 2019
Majkl578
suggested changes
Mar 28, 2019
Majkl578
left a comment
Majkl578
left a comment
Contributor
There was a problem hiding this comment.
Looks ok, besides the ? part. :)
Majkl578
reviewed
Mar 28, 2019
This fixes the phpstan job of the build. Refs doctrine#255
Majkl578
approved these changes
Mar 29, 2019
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the phpstan job of the build.
Refs #255