Drop deprecated FileCacheReader#202
Merged
Merged
Conversation
Majkl578
force-pushed
the
drop-FileCacheReader
branch
from
50f69cb to
b07792a
Compare
Member
|
@Majkl578 needs a rebase. |
Majkl578
force-pushed
the
drop-FileCacheReader
branch
from
b07792a to
fc61827
Compare
lcobucci
suggested changes
May 8, 2018
lcobucci
left a comment
lcobucci
left a comment
Member
There was a problem hiding this comment.
Changes look great, we do have to update UPGRADE.md
Majkl578
force-pushed
the
drop-FileCacheReader
branch
from
fc61827 to
e42c709
Compare
Contributor
Author
|
Yes, yes, I keep forgetting (I guess I need |
lcobucci
approved these changes
May 10, 2018
Member
I also forget that all the time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.