Skip to content

pass: changed the way for checking if password-store is initalized #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdemeester merged 2 commits into from
Sep 25, 2018
Merged

pass: changed the way for checking if password-store is initalized #124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6c1f13
pass: changed the way for checking if password-store is initalized
eyJhb Sep 22, 2018
9c18f03
pass: changed error message returned, if password-store is not initia…
eyJhb Sep 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions pass/pass_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,25 +46,10 @@ func (p Pass) checkInitialized() error {
if passInitialized {
return nil
}
// In principle, we could just run `pass init`. However, pass has a bug
// where if gpg fails, it doesn't always exit 1. Additionally, pass
// uses gpg2, but gpg is the default, which may be confusing. So let's
// just explictily check that pass actually can store and retreive a
// password.
password := "pass is initialized"
name := path.Join(getPassDir(), "docker-pass-initialized-check")

_, err := p.runPassHelper(password, "insert", "-f", "-m", name)
// We just run a `pass ls`, if it fails then pass is not initialized.
_, err := p.runPassHelper("", "ls")
if err != nil {
return fmt.Errorf("error initializing pass: %v", err)
}

stored, err := p.runPassHelper("", "show", name)
if err != nil {
return fmt.Errorf("error fetching password during initialization: %v", err)
}
if stored != password {
return fmt.Errorf("error round-tripping password during initialization: %q != %q", password, stored)
return fmt.Errorf("pass not initialized: %v", err)
}
passInitialized = true
return nil
Expand Down