Repository navigation
Conversation
The session_plan toolset was designed for a host-driven draft/review/execute workflow that never materialised in any known consumer. Removing it keeps the built-in toolset surface single-purpose: shared, named plans go through the plan toolset; there is no per-session variant. Reverts the toolset package, the runtime handlers and event, the registry and catalog entries, the schema enum entries, the example config, and the docs page. Downstream packages that were built to unify shared and session plans (pkg/plans, its CLI/TUI consumers, and cross-references in the session_context docs) still reference the removed toolset and will need a follow-up cleanup from their maintainer to either drop the session scope or re-back it against a different store.
Follows the toolset removal in the previous commit: the concepts and configuration overviews, the /plans TUI browser docs, the plan-toolset doc, the CLI data-dir reference, and the nav all still pointed at docs/tools/session_plan/index.md and its `~/.cagent/session_plans/` storage directory. Prune every dead reference so the docs site builds again.
Contributor
Author
|
Abandoning this direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
session_plantoolset was added to power a host-driven "draft, review, execute" workflow: one agent writes a per-session plan, callsexit_plan_modeto mark it ready, and the host routes the next turn to an executing agent. That workflow never materialised in any known consumer. The toolset ships in every runtime with no active user, and its cross-cutting shape (a whole new event type, a runtime-owned handler set alongsidehandoff/transfer_task, asession_plans/directory under the data dir, a first-class docs page) makes it non-trivial dead weight.Retiring it keeps the built-in toolset surface single-purpose: shared, named plans agents collaborate on across sessions go through the
plantoolset — there is no per-session variant.What this PR removes
A clean inverse of #3305:
sessionplanpackage (pkg/tools/builtin/sessionplan/)pkg/runtime/sessionplan_handlers.go) and the threetoolMapentries inpkg/runtime/loop.goruntime.SessionPlanUpdatedEventand itssession_plan_updatedclient-side registry entrysession_plancreator inpkg/teamloader/toolsets/toolsets.goand the passive catalog entry inpkg/teamloader/toolsets/catalog.gosession_planschema enum entries inagent-schema.jsonexamples/session_plan.yamlanddocs/tools/session_plan/index.mdWhat this PR does NOT touch (deliberate)
pkg/plans(the host-facing plan service) and its consumers (cmd/root/plans,pkg/tui/plans*) were built on top of the session-plan toolset and reference the removed types. They will not compile againstmainafter this lands. Same for a handful of cross-references from thesession_contexttoolset and the CLI/TUI docs pages.Those all sit in a different design surface (unified host-side plan management, with session plans as one of two scopes) whose future shape is not this PR to decide. Options for the follow-up:
Scope,SessionRef,UpdateSession,WithSessionDir, theSessionIDfields onPlan/Ref/ListOptions, theUnsupportedErrortype) — this PR's minimum-viable land-together companion.I'll open the (1) companion PR in a follow-up if that is the direction; happy to sequence differently.
Compatibility
Any external agent config that references
type: session_planwill fail to load with "unknown toolset type" after this lands. Given no known consumer, I've treated it as a straight removal rather than adding a deprecation cycle — happy to invert if a deprecation window is preferred.Users who ran the toolset have
~/.cagent/session_plans/*.mdfiles on disk. Nothing under the runtime enumerates them any longer; they can be removed withrm -rf ~/.cagent/session_plansto reclaim the space.Test status
go buildandgo testpass in every package this PR modifies (pkg/runtime/...,pkg/teamloader/toolsets/...).go build ./...fails only atpkg/plans/service.go— the coordination boundary described above.