Add errors to ProjectError message, duplicate code#8063
Closed
sezanzeb wants to merge 5 commits intodocker:masterfrom
Closed
Add errors to ProjectError message, duplicate code#8063sezanzeb wants to merge 5 commits intodocker:masterfrom
sezanzeb wants to merge 5 commits intodocker:masterfrom
Conversation
sezanzeb
requested review from
aiordache,
ndeloof,
rumpl and
ulyssessouza
as code owners
added 4 commits
January 22, 2021 15:15
Signed-off-by: tobiasb <tobias.brigl@voltstorage.com> Signed-off-by: sezanzeb <proxima@hip70890b.de>
Signed-off-by: tobiasb <tobias.brigl@voltstorage.com> Signed-off-by: sezanzeb <proxima@hip70890b.de>
Signed-off-by: tobiasb <tobias.brigl@voltstorage.com> Signed-off-by: sezanzeb <proxima@hip70890b.de>
Signed-off-by: tobiasb <tobias.brigl@voltstorage.com> Signed-off-by: sezanzeb <proxima@hip70890b.de>
sezanzeb
changed the title
Author
|
Bump @aiordache, I hope you don't mind. |
Author
|
@ndeloof, anyone? This is a really small change that only adds code quality and improved debugging, nothing fancy that would take long to review. I'd like to avoid having this contribution lost forever, this change was important for me to fix some problems. |
Contributor
|
Thanks for taking the time to create this issue/pull request! Unfortunately, Docker Compose V1 has reached end-of-life and we are not accepting any more changes (except for security issues). Please try and reproduce your issue with Compose V2 or rewrite your pull request to be based on the v2 branch and create a new issue or PR with the relevant Compose V2 information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8062
the error is now being printed