Fix .github/CODEOWNERS patterns - #356
Merged
Merged
Conversation
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
=======================================
Coverage 45.47% 45.47%
=======================================
Files 193 193
Lines 16061 16061
=======================================
Hits 7304 7304
Misses 8379 8379
Partials 378 378 |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently they use https://git-scm.com/docs/gitignore#_pattern_format
I'm not sure if these
**are necessary, the doc suggests that just a/might work.I tried testing these against my fork, but nothing works there. I also tried testing by modifying files in this PR, which also doesn't work. I'm guessing it has to be in master.