Skip to content

[Improvement] Wait on waitgroup instead of using time.Sleep when retrieving stats for named containers #2784

Description

@bn4t

Description

Relevant Code: https://github.com/docker/cli/blob/master/cli/command/container/stats.go#L175

Instead of using a fixed time.Sleep(1500 * time.Millisecond) when collecting stats for named containers, just wait on the waitFirst waitgroup instead.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions