Do not drop OS version when converting build options to solver option frontend attributes - #4008
Open
brandond wants to merge 2 commits into
Open
Do not drop OS version when converting build options to solver option frontend attributes#4008brandond wants to merge 2 commits into
brandond wants to merge 2 commits into
Conversation
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Author
brandond
added a commit
to brandond/rke2
that referenced
this pull request
Aug 11, 2026
Builds platform-version-specific images for rke2-runtime so that we can pass the os version in the --platform when saving to tarball. Versions match those available for the pause image, which is the only other thing in the tarball. This requires locally building and using a verison of buildx that does not drop the version from the platform arg; for more information see: docker/buildx#4008 Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/rke2
that referenced
this pull request
Aug 11, 2026
Builds platform-version-specific images for rke2-runtime so that we can pass the os version in the --platform when saving to tarball. Versions match those available for the pause image, which is the only other thing in the tarball. This requires locally building and using a verison of buildx that does not drop the version from the platform arg; for more information see: docker/buildx#4008 Building multi-platform images requires enabling docker's containerd snapshotter in the CI pipeline, a change we made a while ago on the k3s side. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/rke2
that referenced
this pull request
Aug 11, 2026
Builds platform-version-specific images for rke2-runtime so that we can pass the os version in the --platform when saving to tarball. Versions match those available for the pause image, which is the only other thing in the tarball. This requires locally building and using a verison of buildx that does not drop the version from the platform arg; for more information see: docker/buildx#4008 Building multi-platform images requires enabling docker's containerd snapshotter in the CI pipeline, a change we made a while ago on the k3s side. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/rke2
that referenced
this pull request
Aug 11, 2026
Builds platform-version-specific images for rke2-runtime so that we can pass the os version in the --platform when saving to tarball. Versions match those available for the pause image, which is the only other thing in the tarball. This requires locally building and using a verison of buildx that does not drop the version from the platform arg; for more information see: docker/buildx#4008 Building multi-platform images requires enabling docker's containerd snapshotter in the CI pipeline, a change we made a while ago on the k3s side. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/rke2
that referenced
this pull request
Aug 11, 2026
Builds platform-version-specific images for rke2-runtime so that we can pass the os version in the --platform when saving to tarball. Versions match those available for the pause image, which is the only other thing in the tarball. This requires locally building and using a verison of buildx that does not drop the version from the platform arg; for more information see: docker/buildx#4008 Building multi-platform images requires enabling docker's containerd snapshotter in the CI pipeline, a change we made a while ago on the k3s side. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/rke2
that referenced
this pull request
Aug 11, 2026
Builds platform-version-specific images for rke2-runtime so that we can pass the os version in the --platform when saving to tarball. Versions match those available for the pause image, which is the only other thing in the tarball. This requires locally building and using a verison of buildx that does not drop the version from the platform arg; for more information see: docker/buildx#4008 Building multi-platform images requires enabling docker's containerd snapshotter in the CI pipeline, a change we made a while ago on the k3s side. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
crazy-max
previously approved these changes
Aug 11, 2026
crazy-max
left a comment
crazy-max
left a comment
Member
There was a problem hiding this comment.
LGTM thanks
Pushed extra commit to add integration test
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
platforms_format_all
branch
from
August 11, 2026 13:38
ace4c7d to
0ea6302
Compare
crazy-max
approved these changes
Aug 11, 2026
brandond
added a commit
to brandond/rke2
that referenced
this pull request
Aug 11, 2026
Builds platform-version-specific images for rke2-runtime so that we can pass the os version in the --platform when saving to tarball. Versions match those available for the pause image, which is the only other thing in the tarball. This requires locally building and using a verison of buildx that does not drop the version from the platform arg; for more information see: docker/buildx#4008 Building multi-platform images requires enabling docker's containerd snapshotter in the CI pipeline, a change we made a while ago on the k3s side. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/rke2
that referenced
this pull request
Aug 11, 2026
Builds platform-version-specific images for rke2-runtime so that we can pass the os version in the --platform when saving to tarball. Versions match those available for the pause image, which is the only other thing in the tarball. This requires locally building and using a verison of buildx that does not drop the version from the platform arg; for more information see: docker/buildx#4008 Building multi-platform images requires enabling docker's containerd snapshotter in the CI pipeline, a change we made a while ago on the k3s side. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/rke2
that referenced
this pull request
Aug 11, 2026
Builds platform-version-specific images for rke2-runtime so that we can pass the os version in the --platform when saving to tarball. Versions match those available for the pause image, which is the only other thing in the tarball. This requires locally building and using a verison of buildx that does not drop the version from the platform arg; for more information see: docker/buildx#4008 Building multi-platform images requires enabling docker's containerd snapshotter in the CI pipeline, a change we made a while ago on the k3s side. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/rke2
that referenced
this pull request
Aug 11, 2026
Builds platform-version-specific images for rke2-runtime so that we can pass the os version in the --platform when saving to tarball. Versions match those available for the pause image, which is the only other thing in the tarball. This requires locally building and using a verison of buildx that does not drop the version from the platform arg; for more information see: docker/buildx#4008 Building multi-platform images requires enabling docker's containerd snapshotter in the CI pipeline, a change we made a while ago on the k3s side. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/rke2
that referenced
this pull request
Aug 11, 2026
Builds platform-version-specific images for rke2-runtime so that we can pass the os version in the --platform when saving to tarball. Versions match those available for the pause image, which is the only other thing in the tarball. This requires locally building and using a verison of buildx that does not drop the version from the platform arg; for more information see: docker/buildx#4008 Building multi-platform images requires enabling docker's containerd snapshotter in the CI pipeline, a change we made a while ago on the k3s side. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/rke2
that referenced
this pull request
Aug 11, 2026
Builds platform-version-specific images for rke2-runtime so that we can pass the os version in the --platform when saving to tarball. Versions match those available for the pause image, which is the only other thing in the tarball. This requires locally building and using a verison of buildx that does not drop the version from the platform arg; for more information see: docker/buildx#4008 Building multi-platform images requires enabling docker's containerd snapshotter in the CI pipeline, a change we made a while ago on the k3s side. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/rke2
that referenced
this pull request
Aug 11, 2026
Builds platform-version-specific images for rke2-runtime so that we can pass the os version in the --platform when saving to tarball. Versions match those available for the pause image, which is the only other thing in the tarball. This requires locally building and using a verison of buildx that does not drop the version from the platform arg; for more information see: docker/buildx#4008 Building multi-platform images requires enabling docker's containerd snapshotter in the CI pipeline, a change we made a while ago on the k3s side. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to rancher/rke2
that referenced
this pull request
Aug 12, 2026
Builds platform-version-specific images for rke2-runtime so that we can pass the os version in the --platform when saving to tarball. Versions match those available for the pause image, which is the only other thing in the tarball. This requires locally building and using a verison of buildx that does not drop the version from the platform arg; for more information see: docker/buildx#4008 Building multi-platform images requires enabling docker's containerd snapshotter in the CI pipeline, a change we made a while ago on the k3s side. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to moby/buildkit#5614
The process of converting
build.Optionstoclient.SolveOptusesplatforms.Format()to build the string, which does not include the OS version. This causes the OS version to be dropped:buildx build --platform 'windows(10.0.17763)/amd64,windows(10.0.20348)/amd64,windows(10.0.26100)/amd64'becomesso.FrontendAttrs{"platform": "windows/amd64,windows/amd64,windows/amd64"}when submitting the solve request.