chore: remove unneeded excludes - #3552
Merged
Merged
Conversation
The upstream PR that used the pseudo-versions was merged so this no longer causes an upgrade of those dependencies to pseudo-versions so the exclude is no longer needed. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
Member
|
Was hoping we could remove it from Buildkit as well, but looks like go mod graph | grep ' github.com/davecgh/go-spew@v1.1.2'
github.com/moby/buildkit github.com/davecgh/go-spew@v1.1.2-0.20180830191138-d8f796af33cc
github.com/containerd/accelerated-container-image@v1.3.0 github.com/davecgh/go-spew@v1.1.2-0.20180830191138-d8f796af33cc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream PR that used the pseudo-versions was merged so this no
longer causes an upgrade of those dependencies to pseudo-versions so the
exclude is no longer needed.
Relates to #608.