Skip to content

Increase ls and inspect timeouts #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonistiigi merged 2 commits into from
Aug 21, 2020
Merged

Increase ls and inspect timeouts #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14b7936
Increase ls timeout from 7 to 20 seconds
saulshanabrook Jul 16, 2020
c00c5a8
Increase inspect timeout from 5 to 20 seconds
saulshanabrook Jul 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion commands/inspect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func runInspect(dockerCli command.Cli, in inspectOptions) error {

ngi := &nginfo{ng: ng}

timeoutCtx, cancel := context.WithTimeout(ctx, 5*time.Second)
timeoutCtx, cancel := context.WithTimeout(ctx, 20*time.Second)
defer cancel()

err = loadNodeGroupData(timeoutCtx, dockerCli, ngi)
Expand Down
2 changes: 1 addition & 1 deletion commands/ls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func runLs(dockerCli command.Cli, in lsOptions) error {
}
defer release()

ctx, cancel := context.WithTimeout(ctx, 7*time.Second)
ctx, cancel := context.WithTimeout(ctx, 20*time.Second)
defer cancel()

ll, err := txn.List()
Expand Down