[v0.21 backport] vendor: docker, docker/cli v28.0.0-rc.2 - #2996
Merged
Merged
Conversation
full diff: https://github.com/docker/docker/compare/v27.5.1..v28.0.0-rc.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: https://github.com/docker/cli/compare/v27.5.1..v28.0.0-rc.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
crazy-max
requested review from
glours,
jsternberg,
thaJeztah,
thompson-shaun,
tonistiigi and
vvoland
February 14, 2025 13:53
Contributor
|
update to v28 rc2 now? |
Member
Author
full diff: moby/moby@v28.0.0-rc.1...v28.0.0-rc.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: docker/cli@v28.0.0-rc.1...v28.0.0-rc.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
crazy-max
changed the title
Member
Author
|
Added backport of #2998 |
crazy-max
marked this pull request as ready for review
February 17, 2025 16:33
thompson-shaun
approved these changes
Feb 17, 2025
vvoland
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of
We don't usually ship unstable releases, that's why Docker 28 RC bump on master got reverted before making our first RC:
But as discussed internally, Compose needs new network-related features from Docker 28 (cc @ndeloof @glours @thaJeztah). And because the Docker API have signature changes, Compose would not be able to vendor Docker 28.0.0-rc.1 with Buildx 0.21.0 as we are using the latest Docker 27.5.1 stable in current RC: https://github.com/docker/buildx/blob/v0.21.0-rc2/go.mod#L22
Compose could just vendor Buildx master but if patches are released in 0.21 branch, Compose might need to rely on it and would therefore be in broken state with vendoring. I don't think we have other choice than vendoring Docker 28 RC for this Buildx release.