This repository was archived by the owner on Aug 20, 2021. It is now read-only.
Remove profile dependency from implementation code generation - #80
Merged
Conversation
anweiss
reviewed
Feb 4, 2019
| "html/template" | ||
| ) | ||
|
|
||
| //GetImplementationTemplate gets implementation template for implementation go struct file |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| //GetImplementationTemplate gets implementation template for implementation go struct file | |
| // GetImplementationTemplate gets implementation template for implementation go struct file |
Contributor
|
Looks good @minhaj10p. Please rebase and we can merge. |
minhaj10p
force-pushed
the
impl-excel-param
branch
from
February 7, 2019 16:04
4e5623b to
248f581
Compare
minhaj10p
force-pushed
the
impl-excel-param
branch
from
February 7, 2019 16:07
248f581 to
b49646f
Compare
anweiss
reviewed
Feb 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ImplementsProfilesection from control excel sheet