This repository was archived by the owner on Aug 20, 2021. It is now read-only.
Add bash test target to run generate code before the test_util - #72
Merged
Merged
Conversation
Remove doc.go because generate code will run before the test using the bash script Update Makefile to run the bash script with the provided NIST profiles in test_util/artifacts Update Makefile to exclude the go files in test_util since they will be run using the bash script Add NIST profiles and catalog in test_util/artifacts Add oscal-profile-schema and oscal-prose-module for validator_test.go Signed-off-by: farhankamalkhan <farhankamalkhan@gmail.com>
This was referenced Jan 28, 2019
anweiss
approved these changes
Jan 28, 2019
anweiss
left a comment
anweiss
left a comment
Contributor
There was a problem hiding this comment.
Looks solid. Thanks a ton @farhan-khan30!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove doc.go because generate code will run before the test using the bash script
Update Makefile to run the bash script with the provided NIST profiles in test_util/artifacts
Update Makefile to exclude the go files in test_util since they will be run using the bash script
Add NIST profiles and catalog in test_util/artifacts
Add oscal-profile-schema and oscal-prose-module for validator_test.go
Signed-off-by: farhankamalkhan farhankamalkhan@gmail.com