Skip to content
This repository was archived by the owner on Aug 20, 2021. It is now read-only.

Missing profile title workaround and move part traversal to separate file - #68

Merged
anweiss merged 1 commit into
docker-archive:masterfrom
anweiss:profile-metaschema-workaround
Jan 26, 2019
Merged

Missing profile title workaround and move part traversal to separate file#68
anweiss merged 1 commit into
docker-archive:masterfrom
anweiss:profile-metaschema-workaround

Conversation

@anweiss

@anweiss anweiss commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

Per usnistgov/OSCAL#287, the profile metaschema is also missing a title field reference from the model of the profile assembly definition. This addresses that. The part traversal code has also been moved to a separate file so as not to clash with the automatically generate catalog source code.

@minhaj10p for review.

@anweiss anweiss added the bug Something isn't working label Jan 25, 2019
@anweiss anweiss added this to the OSCAL 1.0 milestone Jan 25, 2019
@anweiss anweiss self-assigned this Jan 25, 2019
@anweiss
anweiss requested a review from minhaj10p January 25, 2019 17:48
@anweiss
anweiss force-pushed the profile-metaschema-workaround branch from 6426507 to da62288 Compare January 25, 2019 17:49
@anweiss
anweiss force-pushed the profile-metaschema-workaround branch from da62288 to 6906d91 Compare January 25, 2019 17:50

@minhaj10p minhaj10p left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anweiss
anweiss merged commit 03c89ae into docker-archive:master Jan 26, 2019
@anweiss
anweiss deleted the profile-metaschema-workaround branch January 26, 2019 21:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants