This repository was archived by the owner on Aug 20, 2021. It is now read-only.
Set param - #64
Merged
Merged
Conversation
asadullah-yousuf-10p
suggested changes
Jan 24, 2019
asadullah-yousuf-10p
left a comment
asadullah-yousuf-10p
left a comment
Contributor
There was a problem hiding this comment.
See my comment.
|
|
||
| } | ||
|
|
||
| func TestProcessSetParam(t *testing.T) { |
Contributor
There was a problem hiding this comment.
@minhaj10p can we write a negative test case as well to make sure that if a parameter isn't found in a prose, it shouldn't be changed after applying a profile?
Contributor
Author
There was a problem hiding this comment.
adding negative test
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds processing for profile
set-paramin catalog code/xml/json generationDependencies
This PR to be merged after #58 having transitive dependency of #52