Skip to content
This repository was archived by the owner on Aug 20, 2021. It is now read-only.

Add sub commands for generate cmd - #62

Merged
anweiss merged 1 commit into
docker-archive:masterfrom
minhaj10p:subcommand
Jan 23, 2019
Merged

Add sub commands for generate cmd#62
anweiss merged 1 commit into
docker-archive:masterfrom
minhaj10p:subcommand

Conversation

@minhaj10p

@minhaj10p minhaj10p commented Jan 23, 2019

Copy link
Copy Markdown
Contributor

Description

Adds subcommands to the parent generate command; enabling json/xml catalogs and, go catalogs and Prose parsing yet to be developed.

Links

Partially addressess issue #61. catalog.Prose parsing is yet to be addressed

@asadullah-yousuf-10p asadullah-yousuf-10p left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one update required. Otherwise, LGTM.

// Catalog generates json/xml catalogs
var Catalog = cli.Command{
Name: "catalogs",
Usage: "generates json/xml catalogs provided profile",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Usage: "generates json/xml catalogs provided profile",
Usage: "generates json/xml catalogs when provided with a profile",

@anweiss anweiss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anweiss
anweiss merged commit 2f8e944 into docker-archive:master Jan 23, 2019
@anweiss anweiss mentioned this pull request Jan 23, 2019
@minhaj10p
minhaj10p deleted the subcommand branch January 23, 2019 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants