This repository was archived by the owner on Aug 20, 2021. It is now read-only.
Tidying up some of the core OSCAL methods - #44
Merged
Conversation
anweiss
force-pushed
the
core-oscal-cleanup
branch
from
January 26, 2019 21:46
ac399ca to
6323036
Compare
anweiss
changed the title
anweiss
force-pushed
the
core-oscal-cleanup
branch
from
January 28, 2019 17:38
afdd016 to
1c11517
Compare
asadullah-yousuf-10p
suggested changes
Jan 28, 2019
asadullah-yousuf-10p
left a comment
asadullah-yousuf-10p
left a comment
Contributor
There was a problem hiding this comment.
Just a couple of suggestions.
Contributor
Author
|
@asadullah-yousuf-10p updated per your suggestions. Let me know what you think. Thanks. |
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tidying up some of the core OSCAL methods. Accept
io.Writeras appropriate. Removed CC0 Public Domain header from all source code files in favor of blanketLICENSEfile at the root.