Skip to content
This repository was archived by the owner on Aug 20, 2021. It is now read-only.

Add component guid mapping from excel - #34

Merged
anweiss merged 3 commits into
docker-archive:masterfrom
minhaj10p:master
Jan 14, 2019
Merged

Add component guid mapping from excel#34
anweiss merged 3 commits into
docker-archive:masterfrom
minhaj10p:master

Conversation

@minhaj10p

Copy link
Copy Markdown
Contributor

Added UUIDs against component checks in the excel sheet so that we don't end up generating new UUIDs everytime a new implementation code is generated. This PR addresses the mentioned integration.

Comment thread impl/implementation.go Outdated
anweiss
anweiss previously approved these changes Jan 10, 2019

@anweiss anweiss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anweiss anweiss added the enhancement New feature or request label Jan 11, 2019
@anweiss

anweiss commented Jan 11, 2019

Copy link
Copy Markdown
Contributor

@minhaj10p once #37 is merged, you can go ahead and rebase this PR and we'll get it submitted.

Comment thread impl/implementation.go Outdated
@anweiss

anweiss commented Jan 12, 2019

Copy link
Copy Markdown
Contributor

@minhaj10p #37 has been merged. Please rebase master onto this PR and we'll get this merged as well.

@minhaj10p

Copy link
Copy Markdown
Contributor Author

@anweiss I have rebased my master with upstream. Please go ahead and merge this PR. Thanks!

@anweiss
anweiss merged commit 15f1d5e into docker-archive:master Jan 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants