This repository was archived by the owner on Aug 20, 2021. It is now read-only.
Add implementation code generation - #32
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
===========================================
+ Coverage 65.62% 78.64% +13.01%
===========================================
Files 3 4 +1
Lines 160 309 +149
===========================================
+ Hits 105 243 +138
- Misses 45 52 +7
- Partials 10 14 +4
Continue to review full report at Codecov.
|
Contributor
|
@anweiss @minhaj10p Just a comment. I feel this code generation of |
Contributor
|
LGTM |
Contributor
|
@mohuk per your comment, can you create an issue for us to address the Docker-specific code that was merged in this PR at a later point? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Code generation for Implementation through Excel sheet and input profile.
Uses package https://github.com/satori/go.uuid to generate GUIDs
Usage:
oscalkit implementation -p path-to-profile -e path-to-excelsheet.csv