Skip to content
This repository was archived by the owner on Aug 20, 2021. It is now read-only.

Add implementation code generation - #32

Merged
anweiss merged 2 commits into
docker-archive:masterfrom
minhaj10p:master
Jan 10, 2019
Merged

Add implementation code generation#32
anweiss merged 2 commits into
docker-archive:masterfrom
minhaj10p:master

Conversation

@minhaj10p

@minhaj10p minhaj10p commented Jan 2, 2019

Copy link
Copy Markdown
Contributor

Feature: Code generation for Implementation through Excel sheet and input profile.
Uses package https://github.com/satori/go.uuid to generate GUIDs
Usage: oscalkit implementation -p path-to-profile -e path-to-excelsheet.csv

@minhaj10p minhaj10p closed this Jan 2, 2019
@minhaj10p minhaj10p reopened this Jan 2, 2019
@codecov

codecov Bot commented Jan 2, 2019

Copy link
Copy Markdown

Codecov Report

Merging #32 into master will increase coverage by 13.01%.
The diff coverage is 92.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #32       +/-   ##
===========================================
+ Coverage   65.62%   78.64%   +13.01%     
===========================================
  Files           3        4        +1     
  Lines         160      309      +149     
===========================================
+ Hits          105      243      +138     
- Misses         45       52        +7     
- Partials       10       14        +4
Impacted Files Coverage Δ
generator/mapper.go 81.15% <100%> (ø) ⬆️
generator/reader.go 58.82% <60%> (-2.41%) ⬇️
impl/implementation.go 93.87% <93.87%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a02bb1f...cdd417d. Read the comment docs.

@mohuk

mohuk commented Jan 2, 2019

Copy link
Copy Markdown
Contributor

@anweiss @minhaj10p Just a comment. I feel this code generation of implementation.go shouldn't be part of OSCALkit since the implementation generated is specific to Docker. I am sure we are going to move this out of OSCALkit down the road.

@anweiss anweiss added schema updates Reflects updates to OSCAL schemas enhancement New feature or request and removed schema updates Reflects updates to OSCAL schemas labels Jan 3, 2019
@anweiss

anweiss commented Jan 10, 2019

Copy link
Copy Markdown
Contributor

LGTM

@anweiss anweiss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anweiss
anweiss merged commit a0afab2 into docker-archive:master Jan 10, 2019
@anweiss

anweiss commented Jan 10, 2019

Copy link
Copy Markdown
Contributor

@mohuk per your comment, can you create an issue for us to address the Docker-specific code that was merged in this PR at a later point?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants