Skip to content

Fix 22958 - Bump azure image to windows-2019 - #506

Merged
maxhaton merged 1 commit into
dlang:masterfrom
MoonlightSentinel:bump-azure
Mar 29, 2022
Merged

maxhaton merged 1 commit into
dlang:masterfrom
MoonlightSentinel:bump-azure

Conversation

@MoonlightSentinel

@MoonlightSentinel MoonlightSentinel commented Mar 29, 2022

Copy link
Copy Markdown
Contributor

The current image vs2017-win16 is due for removal.

@maxhaton

@dlang-bot

Copy link
Copy Markdown

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22958 minor [Internal] Installer uses outdated image on Azure

@maxhaton maxhaton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@maxhaton
maxhaton merged commit 532cbd6 into dlang:master Mar 29, 2022
@MoonlightSentinel
MoonlightSentinel deleted the bump-azure branch March 29, 2022 17:33
The current image `vs2017-win16` is due for removal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants