Repository navigation
Conversation
Several checks claimed things the repo does not do, and one claimed a floor the repo cannot actually stand on. Both kinds of drift are fixed: - The Storybook vitest project was removed in v0.2.26, and its only consumer, `.storybook/vitest.setup.ts`, was left behind. Nothing calls setProjectAnnotations; it is deleted. - tsconfig targets ES2022 (was ES2021), matching the Node floor the repo actually runs against, and its include no longer sweeps the generated .velite payload or carries a stale inline comment. - `engines.node` is now ^22.22.2. The previous floor (>=20.9.0) sat under vitest (>=22.12) and jsdom (>=22.22), was on an EOL line, and ignored that the 22 LTS line is where the project is actually developed. Patch releases on the 22 line float in without a config edit. - `qa` used to run the fixing pair (`lint --write`, `format --write`) while claiming to be a check, which made it quietly rewrite the tree and diverge from CI. It now runs the same non-mutating gates as CI. - `storybook` no longer rebuilds the static site before starting dev; `storybook:build` covers the build case explicitly. - README and CONTRIBUTING described commands that do not exist (`test:watch`, `build:analyze`) and Git hooks that are not configured; both now say what is actually wired up. - Production deployments get HSTS (max-age=31536000, includeSubDomains); it is emitted only in production so the dev server over plain HTTP is not poisoned. Verification, unpiped by exit code: `biome check`, `type-check` (against the ES2022 lib set), 269 tests across 35 files with coverage unchanged, a production build, `check:bundle` within budget (1139.9 KB raw / 363.4 KB gzip, narrowly), and the HSTS header present on the production response.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
divijg19
commented
Nov 3, 2026
divijg19
left a comment
divijg19
left a comment
Owner
Author
There was a problem hiding this comment.
v0.2.27: bring the environment tooling back in line with reality
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several checks claimed things the repo does not do, and one claimed a floor the repo cannot actually stand on. Both kinds of drift are fixed:
.storybook/vitest.setup.ts, was left behind. Nothing calls setProjectAnnotations; it is deleted.engines.nodeis now ^22.22.2. The previous floor (>=20.9.0) sat under vitest (>=22.12) and jsdom (>=22.22), was on an EOL line, and ignored that the 22 LTS line is where the project is actually developed. Patch releases on the 22 line float in without a config edit.qaused to run the fixing pair (lint --write,format --write) while claiming to be a check, which made it quietly rewrite the tree and diverge from CI. It now runs the same non-mutating gates as CI.storybookno longer rebuilds the static site before starting dev;storybook:buildcovers the build case explicitly.test:watch,build:analyze) and Git hooks that are not configured; both now say what is actually wired up.Verification, unpiped by exit code:
biome check,type-check(against the ES2022 lib set), 269 tests across 35 files with coverage unchanged, a production build,check:bundlewithin budget (1139.9 KB raw / 363.4 KB gzip, narrowly), and the HSTS header present on the production response.