Repository navigation
Conversation
The vitest config carried a `configLoader: 'native'` warning on every run and a pair of esbuild options the oxc transformer ignored outright, plus a disabled Storybook project whose only purpose was a stale comment. All of it is gone: - `import.meta.dirname` replaces the hand-rolled `__dirname` guard, which is the form the native config loader supports. - The dead `esbuild` blocks are removed; oxc handles JSX natively. - The disabled Storybook project block is removed; nothing ran it and the scaffolding it referenced (`vitest.shims.d.ts`, `@vitest/browser`, `@vitest/ui`) is deleted with it. Storybook itself is untouched. `pool` stays at the default rather than `vmThreads`: vm pools cannot inline the CJS `three` family that `@react-three/drei` requires (the suite's CJS interop throws "Cannot use import statement outside a module" under them), and `isolate: false` reuses one jsdom for everything but leaks state and failed 11 tests across 4 files. The ~16.7s of worker startup the reporter estimates remains unclaimed, and `THREE_CJS_DEPRECATED` still prints once -- both are properties of the upstream three/drei CJS entries, not of the config. Verified unpiped by exit code: `biome check`, `type-check`, `test:ci` (269 tests, 35 files; coverage unchanged and above thresholds), `build`, `check:bundle` within budget, and `test:e2e:smoke` (server raised, smoke passed, server stopped).
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
divijg19
commented
Nov 3, 2026
divijg19
left a comment
divijg19
left a comment
Owner
Author
There was a problem hiding this comment.
v0.2.26: modernise the test stack and drop its dead weight
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vitest config carried a
configLoader: 'native'warning on every run and a pair of esbuild options the oxc transformer ignored outright, plus a disabled Storybook project whose only purpose was a stale comment. All of it is gone:import.meta.dirnamereplaces the hand-rolled__dirnameguard, which is the form the native config loader supports.esbuildblocks are removed; oxc handles JSX natively.vitest.shims.d.ts,@vitest/browser,@vitest/ui) is deleted with it. Storybook itself is untouched.poolstays at the default rather thanvmThreads: vm pools cannot inline the CJSthreefamily that@react-three/dreirequires (the suite's CJS interop throws "Cannot use import statement outside a module" under them), andisolate: falsereuses one jsdom for everything but leaks state and failed 11 tests across 4 files. The ~16.7s of worker startup the reporter estimates remains unclaimed, andTHREE_CJS_DEPRECATEDstill prints once -- both are properties of the upstream three/drei CJS entries, not of the config.Verified unpiped by exit code:
biome check,type-check,test:ci(269 tests, 35 files; coverage unchanged and above thresholds),build,check:bundlewithin budget, andtest:e2e:smoke(server raised, smoke passed, server stopped).