refactor(operator): migrate SchemeBuilder to apimachinery pattern#878
Merged
Merged
Conversation
…ilder
controller-runtime 0.24 deprecated sigs.k8s.io/controller-runtime/pkg/scheme.Builder.
A api package deve depender só de stdlib, k8s.io/apimachinery e outros api packages.
Migrado para o padrão recomendado:
- runtime.NewSchemeBuilder(addKnownTypes) em groupversion_info.go
- addKnownTypes registra todos os 17 CRDs centralmente
- removidos os 17 init() { SchemeBuilder.Register(...) } redundantes
- adicionado metav1.AddToGroupVersion(scheme, GroupVersion) (parte do pattern)
Sem mudança de comportamento: AddToScheme continua sendo a entrypoint,
GroupVersion não muda. Build/test/vet verde.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sigs.k8s.io/controller-runtime/pkg/scheme.Builder(PR upstream #3461).k8s.io/apimachinery+ outros api packages — não de controller-runtime.groupversion_info.goagora usaruntime.NewSchemeBuilder(addKnownTypes)direto do apimachinery.addKnownTypesregistra os 17 CRDs centralmente viascheme.AddKnownTypes(GroupVersion, ...).init() { SchemeBuilder.Register(...) }redundantes (1 por types file).metav1.AddToGroupVersion(scheme, GroupVersion)(parte do padrão).Impacto
AddToSchemecontinua sendo o entrypoint,GroupVersioninalterado.sigs.k8s.io/controller-runtime/pkg/schemenos types.Test plan
go build ./...em /operator — OKgo test ./...em /operator — OK (controllers test passou)go vet ./...em /operator — OK