feat: add DO_IP_ADDR_FAMILIES env var for node address family control#914
Open
lohitkolluri wants to merge 1 commit into
Open
feat: add DO_IP_ADDR_FAMILIES env var for node address family control#914lohitkolluri wants to merge 1 commit into
lohitkolluri wants to merge 1 commit into
Conversation
Add DO_IP_ADDR_FAMILIES environment variable to allow operators to control which IP address families are included in node status. - Introduces DO_IP_ADDR_FAMILIES env var (values: ipv4, ipv6, ipv4,ipv6) - Backward compatible: default includes all available addresses - Refactors nodeAddresses into family-aware discoverAddress helper - Adds comprehensive tests for all family configurations - Updates README and node docs with configuration reference Closes digitalocean#555 Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
Author
|
Hello team just following up on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
DO_IP_ADDR_FAMILIESenvironment variable to control which IP address families are included in node status. This addresses the remaining ask from issue #555 — the basic IPv6 support was already merged in #898 but without the opt-in/opt-out mechanism requested by the maintainer.Changes
DO_IP_ADDR_FAMILIESacceptsipv4,ipv6, oripv4,ipv6(comma-separated)nodeAddressesnow dispatches to a family-awarediscoverAddresshelperRoot Cause
The stale PR #561 implemented the env var approach but was never merged. Since then, basic IPv6 support was merged unconditionally in PR #898. This PR adds the env var gating on top of the current codebase, allowing operators to restrict to specific families.
Testing
make cipasses (go vet, gofmt, unit tests)Risks
DO_IP_ADDR_FAMILIES=ipv4restricts to IPv4 only, which is the key new capability for dual-stack clusters that need to opt out of IPv6 node addressesCloses #555
Signed-off-by: Lohit Kolluri lohitkolluri@gmail.com