Allow foreign executables to explicitly specify "use any found version" with '*' #2758
+19
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashev
commented
Nov 22, 2025
kashev
commented
- a summary of the change
- either
- a link to the issue you are resolving (for small changes)
- a link to the PR you just created (for big changes likely to have discussion)
Member
|
looks great, thanks for the contribution |
Member
|
looks like you need to run |
3 tasks
auto-merge was automatically disabled
November 22, 2025 15:54
Head branch was pushed to by a user without write access
jpraet
reviewed
Feb 3, 2026
| } | ||
| String versionFound = versionMatcher.group(1); | ||
| if (!versionFound.equals(version)) { | ||
| if (!VERSION_WILDCARD.equals(versionFound) && !versionFound.equals(version)) { |
Contributor
There was a problem hiding this comment.
This seems wrong? It should check version for the wildcard, instead of versionFound.
black(java.lang.RuntimeException) You specified version *, but Spotless found 19.10b0 (...)
Author
There was a problem hiding this comment.
@jpraet Agreed :( I will put up a new PR to fix this when I'm able to.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.