Conversation
Your call. |
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
Looks great! Just the tiniest of nitpicks.
| private static Class<?> getClass(State state) { | ||
| if (state.getMavenCoordinate(MAVEN_GROUP_ARTIFACT).isPresent()) | ||
| return state.loadClass(FORMATTER_CLASS); | ||
| return state.loadClass(FORMATTER_CLASS_OLD); |
There was a problem hiding this comment.
Ifs without brackets are dangerous. I would change to this:
if ( ) {
return
} else {
return
}
|
|
||
| @SuppressWarnings("unused") | ||
| private final Set<String> mavenCoordinates; | ||
| private final TreeSet<String> mavenCoordinates; |
There was a problem hiding this comment.
Sorry, I almost missed this one. There are corner-cases where classpath order matters. Unless we have a really compelling reason, I think we should keep this as Set and not TreeSet
There was a problem hiding this comment.
Just wanted to emphasize that I expect a deterministic result for getMavenCoordinates for the same input. I do not insist. What's your final decision?
There was a problem hiding this comment.
then feel free to press the merge button, and I'll test the master integration build on some of my projects
2 participants
Made Spotless-Eclipse-JDT 4.8.0 default version.
Added functionality to lookup Maven Coordinate information from Jar-State as @nedtwigg proposed in #234.
This PR fixes issues #226 and #191.