[ctb]

Requested by someone via e-mail; thought I'd add it to the examples.

Example output:

% python find-nullomers.py ~/dev/sourmash-tutorial/ecoliMG1655.fa.gz  | head
allocating lots of memory for exact counts: 4194304 bytes
consuming /Users/t/dev/sourmash-tutorial/ecoliMG1655.fa.gz
...done!
Iterating over all 11-mers
AAAAAAAAAAA 0
AAAAAAAAAAT 0
AAAAAAAAAAC 0
AAAAAAAAAAG 0
AAAAAAAAATA 3
AAAAAAAAATT 0

• Is it mergeable?
• make test Did it pass the tests?
• make clean diff-cover If it introduces new functionality in
  scripts/ is it tested?
• make format diff_pylint_report cppcheck doc pydocstyle Is it well
  formatted?
• Did it change the command-line interface? Only backwards-compatible
  additions are allowed without a major version increment. Changing file
  formats also requires a major version number increment.
• For substantial changes or changes to the command-line interface, is it
  documented in CHANGELOG.md? See keepachangelog
  for more details.
• Was a spellchecker run on the source code and documentation after
  changes were made?
• Do the changes respect streaming IO? (Are they
  tested for streaming IO?)

[codecov-io]

Codecov Report

Merging #1754 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1754   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files          87      87           
  Lines       11451   11451           
  Branches     3078    3078           
======================================
  Hits            6       6           
  Misses      11445   11445

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e175b...8185a86. Read the comment docs.

[betatim]

Only question: what is a null-o-mer? Was guessing "all kmers with a count of zero" but then it prints all of them.

Otherwise LGTM.

[ctb]

yes, what you thought. I'm asking the requestor what exact output they want.

[betatim]

Merge when ready @ctb

[ctb]

I am saddened by the failure of several different reviewers to test this code... tsk tsk.

[ctb]

And the merge of a PR with none of the checkboxes ticked also seems problematic. tsk tsk.

[luizirber]

http://youshallnotpass.review

…

On Thu, Aug 31, 2017, 5:05 PM C. Titus Brown ***@***.***> wrote: And the merge of a PR with none of the checkboxes ticked also seems problematic. tsk tsk. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1754 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAZ8i763bgibpp2-Q15QPdTc_-Q87-lks5sd0pVgaJpZM4OzSEo> .