Skip to content

Update CPP examples to new oxli/cython setup - #1712

Closed
betatim wants to merge 1 commit into
feature/cython_all_the_thingsfrom
fix/cpp_examples_with_cython
Closed

betatim wants to merge 1 commit into
feature/cython_all_the_thingsfrom
fix/cpp_examples_with_cython

Conversation

@betatim

@betatim betatim commented May 26, 2017 •

Copy link
Copy Markdown
Member

This doesn't contain the modification to setup.py that I needed to make it work locally. Need to decide why/if it is needed or not.

  • Is it mergeable?
  • make test Did it pass the tests?

@betatim

betatim commented May 26, 2017

Copy link
Copy Markdown
Member Author

Paging @camillescott and @standage for cython wisdom and merge.

@betatim

betatim commented May 26, 2017

Copy link
Copy Markdown
Member Author

This PR is against #1595

@standage

Copy link
Copy Markdown
Member

Compiles and runs on my machine :)

@betatim

betatim commented May 29, 2017

Copy link
Copy Markdown
Member Author

Merge?

@standage

Copy link
Copy Markdown
Member

However, I don't understand why it took 45+ seconds of hard thinking to execute make help on this branch, which shouldn't be touching setup.py or anything else in the dev environment AFAICT.

@standage

Copy link
Copy Markdown
Member

I'll defer to @camillescott on merging.

@betatim

betatim commented May 29, 2017

Copy link
Copy Markdown
Member Author

Not sure about make help. My guess would be one of the variables that uses shell is to blame?

@betatim

betatim commented May 30, 2017

Copy link
Copy Markdown
Member Author

Is the make help thing also a problem on the original cython branch?

It would be good if we can keep rolling to get this cython thing done and dusted, so shall we merge this instead of waiting for Camille?

@camillescott

Copy link
Copy Markdown
Member

Welp sorry to say that I fixed this already on the plane to Hawaii last week, but forgot to push the commit. So, closing this pull. Sorry @betatim

@betatim

betatim commented May 31, 2017

Copy link
Copy Markdown
Member Author

Tzz

@betatim
betatim deleted the fix/cpp_examples_with_cython branch May 31, 2017 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants