some bulk sequence loading tests that nail down current ACGTN behavior.

lib/read_parsers.hh

@@ -208,9 +208,11 @@ inline PartitionID _parse_partition_id(std::string name)
     if (*s == '\t') {
         p = (PartitionID) atoi(s + 1);
     } else {
-        std::cerr << "consume_partitioned_fasta barfed on read "
-                  << name << "\n";
-        throw khmer_exception();
+        std::string err;
+        err = "consume_partitioned_fasta cannot find partition ID for read ";
+        err += name;
+
+        throw khmer_value_exception(err);
     }
 
     return p;

tests/test-data/valid-read-testing.fq

@@ -0,0 +1,36 @@
+@895:1:1:1246:14654 1:N:0:NNNNN	1
+CAGGCGCCCACCACCGTGCCCTCCAACCTGATGGT
++
+][aaX__aa[`ZUZ[NONNFNNNNNO_____^RQ_
+@895:1:1:1248:9583 1:N:0:NNNNN	2
+ACTGGGCGTAGACGGTGTCCTCATCGGCACCAGC
++
+\UJUWSSV[JQQWNP]]SZ]ZWU^]ZX][^TXR`
+@895:1:1:1252:19493 1:N:0:NNNNN	3
+CCGGCGTGGTTGGTGAGGTCACTGAGCTTCATGTC
++
+OOOKONNNNN__`R]O[TGTRSY[IUZ]]]__X__
+@895:1:1:1255:18861 1:N:0:NNNNN	4
+ACGACGAGAAGCTGATCTACCGCGCCGAGCGCATC
++
+bb_^^bb_XTbbbbbb_bab]KTITZQTZ]ZYT^^
+@lowercase_to_uppercase	5
+caggcgcccaccaccgtgccctccaacctgatggt
++
+][aaX__aa[`ZUZ[NONNFNNNNNO_____^RQ_
+@n_in_read	6
+ACTGGGCGTAGNCGGTGTCCTCATCGGCACCAGC
++
+\UJUWSSV[JQQWNP]]SZ]ZWU^]ZX][^TXR`
+@zy_in_read	7
+CCGGCGTGGTTZZYAGGTCACTGAGCTTCATGTC
++
+OOOKONNNNN__`R]O[TGTRSY[IUZ]]]__X__
+@895:1:1:1255:18861 1:N:0:NNNNN	8
+ACGACGAGAAGCTGATCTACCGCGCCGAGCGCATC
++
+bb_^^bb_XTbbbbbb_bab]KTITZQTZ]ZYT^^
+@bad_dna_in_beginning	9
+YGAGCTGAGAGCTGAGAGCTGA
++
+bbbbbbbbbbbbbbbbbbbbbb

tests/test_nodegraph.py

@@ -337,6 +337,14 @@ def test_load_partitioned():
     assert nodegraph.get(third_s)
 
 
+def test_consume_partitioned_fail():
+    inpfile = utils.get_test_data('test-reads.fa')
+    nodegraph = khmer._Nodegraph(32, [1])
+
+    with pytest.raises(ValueError):
+        nodegraph.consume_partitioned_fasta(inpfile)
+
+
 def test_count_within_radius_simple():
     inpfile = utils.get_test_data('all-A.fa')
     nodegraph = khmer._Nodegraph(4, [3, 5])