Merged
Conversation
ghost
commented
Apr 22, 2020
ghost
marked this pull request as ready for review
April 22, 2020 15:58
ghost
self-requested a review
as a code owner
April 22, 2020 15:58
amcgee
approved these changes
Apr 22, 2020
amcgee
left a comment
amcgee
left a comment
Contributor
There was a problem hiding this comment.
This seems fine to me, @varl might have more insight since he did the original setup?
Related, if we wanted to run separate jest instances for each package and combine the coverage reports : jestjs/jest#2418
Contributor
|
@ismay is the failing test unrelated? |
Author
Those are tests that were broken somewhere, but that we didn't catch because we weren't running them. So related in a way, but not really. |
varl
approved these changes
Apr 22, 2020
added 3 commits
April 23, 2020 09:13
Otherwise jest will incorrectly recognise it as a test and fail
ghost
deleted the
fix-tests
branch
April 23, 2020 08:35
Contributor
|
🎉 This PR is included in version 5.0.0-alpha.9 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
eirikhaugstulen
added a commit
that referenced
this pull request
Apr 13, 2026
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Eirik <eirik.haugstulen@gmail.com>
eirikhaugstulen
added a commit
that referenced
this pull request
Apr 15, 2026
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Eirik <eirik.haugstulen@gmail.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up to the discussion here: https://dhis2.slack.com/archives/CBM8LNEQM/p1587567537209200
Todo:
__test__and__tests__dirs