Skip to content

docs: fix storybook prefixes - #18

Merged
1 commit merged into
alphafrom
alpha-fix-story-prefixes
Apr 7, 2020
Merged

docs: fix storybook prefixes#18
1 commit merged into
alphafrom
alpha-fix-story-prefixes

Conversation

@ghost

@ghost ghost commented Apr 6, 2020

Copy link
Copy Markdown

I noticed that certain components did not have the prefixes that the others all have (component/widget). I've added it for the ones that were lacking a prefix. I assumed that this was necessary, so feel free to close if this was intentional.

(The changes in the Layer story are changes made by prettier btw)

@ghost
ghost requested a review from varl April 6, 2020 15:27
@ghost
ghost marked this pull request as ready for review April 6, 2020 15:27
@ghost
ghost self-requested a review as a code owner April 6, 2020 15:27
@ghost ghost mentioned this pull request Apr 7, 2020
5 tasks

@HendrikThePendric HendrikThePendric left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are definitely improvements, but please also note that ultimately we want to start using the new recommended syntax, as we are already doing for some components.

@ghost
ghost merged commit 2f52e3f into alpha Apr 7, 2020
@dhis2-bot

Copy link
Copy Markdown
Contributor

@dhis2-bot

Copy link
Copy Markdown
Contributor

@varl
varl deleted the alpha-fix-story-prefixes branch October 27, 2020 14:57
eirikhaugstulen added a commit that referenced this pull request Apr 13, 2026
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Eirik <eirik.haugstulen@gmail.com>
eirikhaugstulen added a commit that referenced this pull request Apr 15, 2026
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Eirik <eirik.haugstulen@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants